chore: Replaces the test utils script with centralized one #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangevolon
force-pushed
the
chore/adds-test-utils-build-scripts
branch
from
8672389 to
d7c3296
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
=======================================
Coverage 93.94% 93.94%
=======================================
Files 61 61
Lines 4312 4312
Branches 741 740 -1
=======================================
Hits 4051 4051
- Misses 259 261 +2
+ Partials 2 0 -2 ☔ View full report in Codecov by Sentry. |
This was referenced Jan 17, 2025
Open
georgylobko
reviewed
Jan 17, 2025
just-boris
reviewed
Jan 17, 2025
orangevolon
force-pushed
the
chore/adds-test-utils-build-scripts
branch
from
d7c3296 to
9bf1415
Compare
orangevolon
force-pushed
the
chore/adds-test-utils-build-scripts
branch
from
9bf1415 to
6ec011f
Compare
just-boris
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
All places where I left comment look good for me. For the rest of the PR, I would count on @georgylobko to give the final ship-it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We moved the test utils generation code to the
test-utilsrepo here. This PR removes the redundant code and reuses the utils exported from thetest-utilsrepo.No functional changes are expected. The snapshot diffs must be only spacings/ordering.
Similar to: cloudscape-design/chat-components#35, cloudscape-design/code-view#54, cloudscape-design/components#3087
How has this been tested?
We have already implemented functional tests both in the
test-utilsrepo andcomponentsrepo which generates actual test utils and tries to query dom with the generated test utils.Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.