Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replaces the test utils generation with centralized code from test-utils package #3087

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

orangevolon
Copy link
Contributor

@orangevolon orangevolon commented Dec 2, 2024

Description

We moved the test utils generation code to the test-utils repo here. This PR removes the redundant code and reuses the utils exported from the test-utils repo.

No functional changes are expected. The snapshot diffs must be only spacings/ordering.

Similar to: cloudscape-design/code-view#54, cloudscape-design/board-components#332, cloudscape-design/chat-components#35

How has this been tested?

We have already implemented functional tests both in the test-utils repo and components repo which generates actual test utils and tries to query dom with the generated test utils.

  • Unit tests for test utils.
  • Unit tests for components.

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@orangevolon orangevolon force-pushed the chore/adds-test-utils-build-scripts branch from a50acb2 to f6e8b06 Compare January 17, 2025 08:47
@orangevolon orangevolon changed the title chore: Replaces the test utils generation chore: Replaces the test utils generation with centralized code from test-utils package Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (89ffd99) to head (04db318).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3087    +/-   ##
========================================
  Coverage   96.42%   96.42%            
========================================
  Files         787      787            
  Lines       22190    22195     +5     
  Branches     7206     7555   +349     
========================================
+ Hits        21396    21401     +5     
+ Misses        787      742    -45     
- Partials        7       52    +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orangevolon orangevolon force-pushed the chore/adds-test-utils-build-scripts branch from f6e8b06 to 04db318 Compare January 17, 2025 11:42
@orangevolon orangevolon marked this pull request as ready for review January 17, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant