-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toyota: Add secoc distance message from PCM #1627
Conversation
Can you provide a drive where you press the distance button? |
Are you looking for a public route added in the PR? Or can I share one just with you for the purpose of this PR? |
Here’s a route where I press the button several times 41ba5b181f29435d/00000036--10383e82d4 |
This is not sent from the camera, so we cannot send it to increment the distance like we normally do by interception. |
You can rename the message to be prefixed like PCM_CRUISE_X and we can merge that though |
Yeah. We won't be able to use this the same way it is used today for other cars. It also looks like the message has secoc but it's a little harder to tell because the freq of the message is much lower than other secoc messages. Still worth documenting the message in the DBC IMO. I will update the name per your suggestion |
Even if we can't send this message to change the distance bars, would it be acceptable to still hookup this button press to change personality? It could get out of sync with the dash but at least would give the ability to change personality without fishing through the settings menu. Or would you recommend using PCM_FOLLOW_DISTANCE to get the current state and set personality off of that? |
That won't work, any changes in the openpilot UI won't be reflected in the dash UI/take effect |
But we could instead have comma listen to the follow distance and update the UI based on the current cars state instead right? |
No description provided.