Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toyota: Add secoc distance message from PCM #1627

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Conversation

chrispypatt
Copy link
Contributor

No description provided.

@sshane
Copy link
Contributor

sshane commented Jan 13, 2025

Can you provide a drive where you press the distance button?

@chrispypatt
Copy link
Contributor Author

chrispypatt commented Jan 13, 2025

Are you looking for a public route added in the PR? Or can I share one just with you for the purpose of this PR?

@chrispypatt
Copy link
Contributor Author

Here’s a route where I press the button several times 41ba5b181f29435d/00000036--10383e82d4

@sshane
Copy link
Contributor

sshane commented Jan 14, 2025

This is not sent from the camera, so we cannot send it to increment the distance like we normally do by interception. cp.vl["PCM_CRUISE_2"]["PCM_FOLLOW_DISTANCE"] still works to get the value. Perhaps the button is now wired to the PCM instead of the camera, so we may not be able to change it remotely unless we explore the ACC messages from the camera further.

@sshane sshane closed this Jan 14, 2025
@sshane
Copy link
Contributor

sshane commented Jan 14, 2025

You can rename the message to be prefixed like PCM_CRUISE_X and we can merge that though

@sshane sshane reopened this Jan 14, 2025
@chrispypatt
Copy link
Contributor Author

Yeah. We won't be able to use this the same way it is used today for other cars. It also looks like the message has secoc but it's a little harder to tell because the freq of the message is much lower than other secoc messages. Still worth documenting the message in the DBC IMO. I will update the name per your suggestion

@chrispypatt chrispypatt changed the title Toyota: Add ACC_CONTROL_3 for secoc DISTANCE Toyota: Add secoc distance message from PCM Jan 14, 2025
@chrispypatt
Copy link
Contributor Author

chrispypatt commented Jan 14, 2025

Even if we can't send this message to change the distance bars, would it be acceptable to still hookup this button press to change personality? It could get out of sync with the dash but at least would give the ability to change personality without fishing through the settings menu.

Or would you recommend using PCM_FOLLOW_DISTANCE to get the current state and set personality off of that?

@sshane
Copy link
Contributor

sshane commented Jan 14, 2025

That won't work, any changes in the openpilot UI won't be reflected in the dash UI/take effect

@sshane sshane merged commit f7aeddf into commaai:master Jan 14, 2025
3 checks passed
@chrispypatt
Copy link
Contributor Author

But we could instead have comma listen to the follow distance and update the UI based on the current cars state instead right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants