-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(NNS): run upgrade_canisters_with_golden_nns_state daily #190
test(NNS): run upgrade_canisters_with_golden_nns_state daily #190
Conversation
This adds the new job `nns-tests-nightly` to the `schedule-daily` workflow which runs the `//rs/nns/integration_tests:upgrade_canisters_with_golden_nns_state` rust test.
Relabeling `bazel-build-fuzzers-weekly` and `cut-release-candidate` to run on different runners. --------- Co-authored-by: IDX GitHub Automation <IDX GitHub Automation>
…-upgrade_canisters_with_golden_nns_state
…-upgrade_canisters_with_golden_nns_state
…-upgrade_canisters_with_golden_nns_state
…-upgrade_canisters_with_golden_nns_state
…_golden_nns_state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this! Been meaning to get this set up.
Can I request that in a future PR, we have a Slack message sent to dev-nns when a run fails? Because it is unlikely that we will poll this. Ideally, failures should be pushed to us.
In the future, we may want automatic retry for flakes. upgrade_canisters_with_golden_nns_state seems to be very not flakey. Therefore, I do not think we need this yet. Would this just a matter of (adding|modifying) a single line of configuration? |
Instead of saying |
That seems like a nice addition. There could be a step like this after the This is also something the NNS team can add themselves after this merges. |
This adds the new job
nns-tests-nightly
to theschedule-daily
workflow which runs the//rs/nns/integration_tests:upgrade_canisters_with_golden_nns_state
rust test.