Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(NNS): run upgrade_canisters_with_golden_nns_state daily #190

Merged

Conversation

basvandijk
Copy link
Collaborator

This adds the new job nns-tests-nightly to the schedule-daily workflow which runs the
//rs/nns/integration_tests:upgrade_canisters_with_golden_nns_state rust test.

This adds the new job `nns-tests-nightly` to the `schedule-daily`
workflow which runs the
`//rs/nns/integration_tests:upgrade_canisters_with_golden_nns_state`
rust test.
@sa-github-api sa-github-api changed the base branch from master to mirroring June 6, 2024 10:15
@github-actions github-actions bot added the chore label Jun 19, 2024
@basvandijk basvandijk marked this pull request as ready for review June 19, 2024 12:47
@basvandijk basvandijk requested review from a team as code owners June 19, 2024 12:47
@basvandijk basvandijk enabled auto-merge June 19, 2024 13:03
Copy link
Contributor

@daniel-wong-dfinity-org daniel-wong-dfinity-org left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this! Been meaning to get this set up.

Can I request that in a future PR, we have a Slack message sent to dev-nns when a run fails? Because it is unlikely that we will poll this. Ideally, failures should be pushed to us.

.github/workflows/schedule-daily.yml Outdated Show resolved Hide resolved
rs/nns/integration_tests/BUILD.bazel Show resolved Hide resolved
@daniel-wong-dfinity-org
Copy link
Contributor

In the future, we may want automatic retry for flakes. upgrade_canisters_with_golden_nns_state seems to be very not flakey. Therefore, I do not think we need this yet. Would this just a matter of (adding|modifying) a single line of configuration?

@daniel-wong-dfinity-org
Copy link
Contributor

Instead of saying chore, in the title, I would suggest maybe test.

@basvandijk
Copy link
Collaborator Author

@daniel-wong-dfinity-org

Can I request that in a future PR, we have a Slack message sent to dev-nns when a run fails?

That seems like a nice addition. There could be a step like this after the bazel-test-all step. bazel-test-all will then need to enable continue-on-error to ensure the job doesn't fail before it sends the slack notification.

This is also something the NNS team can add themselves after this merges.

@basvandijk basvandijk changed the title chore(NNS): run upgrade_canisters_with_golden_nns_state daily test(NNS): run upgrade_canisters_with_golden_nns_state daily Jun 19, 2024
@github-actions github-actions bot added test and removed chore labels Jun 19, 2024
@basvandijk basvandijk added this pull request to the merge queue Jun 19, 2024
Merged via the queue into mirroring with commit 51747a7 Jun 19, 2024
14 checks passed
@marko-k0 marko-k0 deleted the basvandijk/daily-upgrade_canisters_with_golden_nns_state branch July 12, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants