feat: [EXC-1753] Add mint_cycles128 API #2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 13, 2024 09:17
michael-weigelt
commented
Nov 15, 2024
|
Note: The benchmark results will be added this week after the wasmtime upgrade. |
berestovskyy
previously approved these changes
Nov 25, 2024
mraszyk
reviewed
Dec 10, 2024
mraszyk
reviewed
Dec 10, 2024
mraszyk
reviewed
Dec 10, 2024
mraszyk
reviewed
Dec 10, 2024
mraszyk
reviewed
Dec 11, 2024
mraszyk
reviewed
Dec 11, 2024
mraszyk
approved these changes
Dec 11, 2024
This was referenced Dec 12, 2024
Closed
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
) #2589 caused a problem in a backup test in the hourly pipeline, so it was reverted in #3125. #3147 addressed the underlying problem in the backup test and was merged. #3151 is 2589+3147 and shows that the mitigation works, but instead of merging that, it's nicer to revert the revert: This PR reverts #3125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new system API method
ic0_mint_cycles128which, like its predecessoric0_mint_cycles, is not usable by any canister except the CMC. It is therefore not necessary to add it to the interface spec or the SDKs. It also means that this system call does not need an instruction cost adjustment.The method's signature deviates from the predecessor because 128 bit values cannot be handled by WASM natively. Therefore, the argument is split into two
u64s, representing the high and low bits. The amount of actually minted cycles cannot be returned as a WASM return value either. Instead, the result is written to a caller-specified location in memory, where it occupies the next 16 bytes.