Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github npm package release permissions #352

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

mattdean-digicatapult
Copy link
Contributor

@mattdean-digicatapult mattdean-digicatapult commented Jan 7, 2025

Pull Request

Checklist

  • Have you read Digital Catapult's Code of Conduct?
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

PR Type

Please delete options that are irrelevant.

  • Bug Fix
  • Chore
  • Feature
  • Documentation Update
  • Code style update (formatting, local variables)
  • Breaking Change (fix or feature that would cause existing functionality to change)

Linked tickets

https://digicatapult.atlassian.net/browse/SQNC-50

High level description

Fixes a bug in the release of github npm package due to permissions

Detailed description

This PR depends on digicatapult/shared-workflows#18 which adds support for publishing a github npm package using the GITHUB_TOKEN secret.

Note the lack of version bump as the previous release failed

Describe alternatives you've considered

None

Operational impact

See digicatapult/shared-workflows#18 for steps to revert

Additional context

digicatapult/shared-workflows#18

@mattdean-digicatapult mattdean-digicatapult marked this pull request as ready for review January 7, 2025 11:43
@mattdean-digicatapult mattdean-digicatapult requested a review from a team as a code owner January 7, 2025 11:43
@mattdean-digicatapult mattdean-digicatapult merged commit 6408d50 into main Jan 7, 2025
7 checks passed
@mattdean-digicatapult mattdean-digicatapult deleted the bug/fix-release-gh-npm-package branch January 7, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants