fix: broken links in tags #213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imnaiyar
changed the title
almostSouji
reviewed
Aug 12, 2024
| @@ -1008,7 +1008,7 @@ Fetching members can time out on large guilds, as they arrive in chunks through | |||
| keywords = ["custom-properties-on-client"] | |||
| content = """ | |||
| We highly recommend you extend the `Client` structure properly instead of just attaching custom properties like `.commands` to the regular discord.js `Client` instance. | |||
| - Using typescript, you might want to consider [casting](https://www.typescripttutorial.net/typescript-tutorial/type-casting/) or [augmenting the module type](https://www.typescriptlang.org/docs/handbook/modules.html#ambient-modules) | |||
| - Using typescript, you might want to consider [casting](https://www.typescripttutorial.net/typescript-tutorial/type-casting/) or [augmenting the module type](https://www.typescriptlang.org/docs/handbook/modules/reference.html#ambient-modules) | |||
There was a problem hiding this comment.
Ambient module declarations are easy to confuse with module augmentations since they use identical syntax.
That seems to be precisely what happened in this tag and this was meant to link to module augmentation in the first place
Wolvinny
pushed a commit
to Wolvinny/discord-utils-bot
that referenced
this pull request
Aug 27, 2024
* fix typescript docs link (should be type augmentation, not ambient modules) resolves discordjs#213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tags: