Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken links in tags #213

Closed
wants to merge 2 commits into from
Closed

fix: broken links in tags #213

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd49cfc
fix broken link in custom-client-properties tag
imnaiyar Jul 30, 2024
02c1e8d
fix broken link in embed-limits tag
imnaiyar Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tags/tags.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ Learn more about slash command limits at the [Discord Developer Documentation](h
[embed-limits]
keywords = ["embedlimits"]
content = """
Learn more about embed limits at the [Discord Developer Documentation](https://discord.com/developers/docs/resources/channel#embed-object-embed-limits)
Learn more about embed limits at the [Discord Developer Documentation](https://discord.com/developers/docs/resources/message#embed-object-embed-limits)
"""

[button-limits]
Expand Down Expand Up @@ -1008,7 +1008,7 @@ Fetching members can time out on large guilds, as they arrive in chunks through
keywords = ["custom-properties-on-client"]
content = """
We highly recommend you extend the `Client` structure properly instead of just attaching custom properties like `.commands` to the regular discord.js `Client` instance.
- Using typescript, you might want to consider [casting](https://www.typescripttutorial.net/typescript-tutorial/type-casting/) or [augmenting the module type](https://www.typescriptlang.org/docs/handbook/modules.html#ambient-modules)
- Using typescript, you might want to consider [casting](https://www.typescripttutorial.net/typescript-tutorial/type-casting/) or [augmenting the module type](https://www.typescriptlang.org/docs/handbook/modules/reference.html#ambient-modules)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ambient module declarations are easy to confuse with module augmentations since they use identical syntax.

That seems to be precisely what happened in this tag and this was meant to link to module augmentation in the first place

"""

[components-per-message]
Expand Down
Loading