Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow names to include platform #3799

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Jan 13, 2025

Task/Issue URL: https://app.asana.com/0/72649045549333/1209141686015372/f
Tech Design URL:
CC:

Description:

This PR makes the following changes:

  1. Renames workflow files to be prefixed by ios-
  2. Updates references to workflow files to account for this renaming - only one rename was needed, within ios-nightly.yml

Steps to test this PR:

  1. Check that workflow names look correct
  2. Check that no workflow references have been overlooked
  3. Check that CI is green

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons marked this pull request as ready for review January 13, 2025 23:40
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @samsymons. This looks good, but as discussed in Asana, we'd prefer to have workflow names prefixed with the platform name, rather than suffixed. Could you update the names accordingly, please? (e.g. "iOS - End-to-End tests") Thank you!

@samsymons samsymons requested a review from ayoy January 14, 2025 16:22
Comment on lines -1 to +2
name: Danger JS
on:
name: iOS - Danger JS
on:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, I decided to add the iOS - prefix to all workflows, even those we expect will get combined into a single workflow later. It just reads nicer in the PR checks section, and won't slow down the monorepo implementation.

Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@samsymons samsymons merged commit b7bdaa4 into release/7.153.0 Jan 14, 2025
13 checks passed
@samsymons samsymons deleted the sam/release-pr-rename-workflows branch January 14, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants