-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update workflow names to include platform #3799
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @samsymons. This looks good, but as discussed in Asana, we'd prefer to have workflow names prefixed with the platform name, rather than suffixed. Could you update the names accordingly, please? (e.g. "iOS - End-to-End tests") Thank you!
name: Danger JS | ||
on: | ||
name: iOS - Danger JS | ||
on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, I decided to add the iOS -
prefix to all workflows, even those we expect will get combined into a single workflow later. It just reads nicer in the PR checks section, and won't slow down the monorepo implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏
Task/Issue URL: https://app.asana.com/0/72649045549333/1209141686015372/f
Tech Design URL:
CC:
Description:
This PR makes the following changes:
ios-
ios-nightly.yml
Steps to test this PR:
Definition of Done (Internal Only):
Copy Testing:
’
rather than'
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template