Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow names to include platform #3799

Merged
merged 4 commits into from
Jan 14, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Make ad-hoc build
name: Make ad-hoc build (iOS)

on:
workflow_dispatch:
Expand Down Expand Up @@ -53,7 +53,7 @@ jobs:
if [[ "${{ github.event.inputs.build-type }}" == "Release" ]]; then
lane_to_use="release_adhoc"
fi

if [[ -n "${{ github.event.inputs.suffix }}" ]]; then
bundle exec fastlane ${lane_to_use} suffix:${{ github.event.inputs.suffix }}
else
Expand Down Expand Up @@ -81,7 +81,7 @@ jobs:
with:
name: ${{ env.dsyms_filename }}
path: ${{ env.dsyms_path }}

- name: Get Asana Task ID
id: get-task-id
if: github.event.inputs.asana-task-url
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Make TestFlight Alpha Build
name: Make TestFlight Alpha Build (iOS)

on:
workflow_dispatch:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: End-to-End tests
name: End-to-End tests (iOS)

on:
schedule:
Expand All @@ -10,7 +10,7 @@ jobs:
name: Build End to End Tests
runs-on: macos-15-xlarge
timeout-minutes: 30

steps:
- name: Check out the code
uses: actions/checkout@v3
Expand Down Expand Up @@ -54,7 +54,7 @@ jobs:
with:
name: duckduckgo-ios-app
path: DerivedData/Build/Products/Debug-iphonesimulator/DuckDuckGo.app

- name: Upload logs when workflow failed
uses: actions/upload-artifact@v4
if: failure() || cancelled()
Expand All @@ -73,7 +73,7 @@ jobs:
strategy:
matrix:
test-tag: [release, privacy, securityTest, adClick]
max-parallel: 1 # Uncomment this line to run tests sequentially.
max-parallel: 1 # Uncomment this line to run tests sequentially.
fail-fast: false

steps:
Expand All @@ -94,7 +94,7 @@ jobs:
- name: End to End tests
run: |
export PATH="$PATH":"$HOME/.maestro/bin"; maestro cloud --apiKey ${{ secrets.ROBIN_API_KEY }} --project-id ${{ secrets.ROBIN_PROJECT_KEY }} -e ONBOARDING_COMPLETED=true --fail-on-timeout=true --fail-on-cancellation=true --timeout=150 --ios-version=17 --include-tags=${{ matrix.test-tag }} DerivedData/Build/Products/Debug-iphonesimulator/DuckDuckGo.app .maestro/

# notify-failure:
# name: Notify on failure
# if: ${{ always() && contains(join(needs.*.result, ','), 'failure') && github.ref_name == 'main' }}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Nightly Test and Deploy
name: Nightly Test and Deploy (iOS)

on:
schedule:
Expand Down Expand Up @@ -100,7 +100,7 @@ jobs:

deploy-alpha:
name: Deploy Nightly Alpha Build
uses: ./.github/workflows/alpha.yml
uses: ./.github/workflows/ios-alpha.yml
with:
destination: "Nightly Alpha Group"
secrets:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: PR Checks
name: PR Checks (iOS)

on:
push:
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Asana PR Task URL

on:
on:
pull_request:
types: [opened, edited, closed, synchronize, review_requested, ready_for_review]

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Promote TestFlight to App Store
name: Promote TestFlight to App Store (iOS)

on:
on:
workflow_dispatch: {}

jobs:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Make App Store Connect Release
name: Make App Store Connect Release (iOS)

on:
workflow_dispatch:
Expand Down Expand Up @@ -92,10 +92,10 @@ jobs:
else
echo "::error::Asana Task URL has incorrect format (attempted to match ${task_url_regex})."
fi

- name: Upload debug symbols to Asana
if: ${{ always() && github.event.inputs.asana-task-url }}
env:
env:
ASANA_ACCESS_TOKEN: ${{ secrets.ASANA_ACCESS_TOKEN }}
run: |
if [[ -f ${{ env.dsyms_path }} ]]; then
Expand Down Expand Up @@ -129,8 +129,8 @@ jobs:

if [[ -z "${MM_USER_HANDLE}" ]]; then
echo "Mattermost user handle not known for ${{ github.actor }}, skipping sending message"
else
else
curl -s -H 'Content-type: application/json' \
-d "$(envsubst < ./scripts/assets/appstore-release-mm-template.json | jq ".${{ job.status }}")" \
${{ secrets.MM_WEBHOOK_URL }}
fi
fi
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Sync-End-to-End tests
name: Sync-End-to-End tests (iOS)

on:
schedule:
Expand Down Expand Up @@ -54,7 +54,7 @@ jobs:
with:
name: duckduckgo-ios-app
path: DerivedData/Build/Products/Debug-iphonesimulator/DuckDuckGo.app

- name: Upload logs when workflow failed
uses: actions/upload-artifact@v4
if: failure() || cancelled()
Expand All @@ -64,7 +64,7 @@ jobs:
xcodebuild.log
DerivedData/Logs/Test/*.xcresult
retention-days: 7

sync-end-to-end-tests:
name: Sync End To End Tests
needs: build-for-sync-end-to-end-tests
Expand All @@ -73,9 +73,9 @@ jobs:
strategy:
matrix:
os-version: [17] #[15, 16, 17]
max-parallel: 1 # Uncomment this line to run tests sequentially.
max-parallel: 1 # Uncomment this line to run tests sequentially.
fail-fast: false

steps:
- name: Check out the code
uses: actions/checkout@v3 # Don't need submodules here as this is only for the tests folder
Expand All @@ -85,7 +85,7 @@ jobs:
id: sync-recovery-code
with:
debug: true

- name: Retrieve Binary
uses: actions/download-artifact@v4
with:
Expand All @@ -95,19 +95,19 @@ jobs:
- name: Install Maestro
run: |
export MAESTRO_VERSION=1.39.1; curl -Ls "https://get.maestro.mobile.dev" | bash

- name: Overwrite default config with sync one
run: |
cp .maestro/config-sync .maestro/config.yaml
- name: Sync e2e tests

- name: Sync e2e tests
run: |
export PATH="$PATH":"$HOME/.maestro/bin"; maestro cloud --apiKey ${{ secrets.ROBIN_API_KEY }} --project-id ${{ secrets.ROBIN_PROJECT_KEY }} -e ONBOARDING_COMPLETED=true --env=CODE=${{ steps.sync-recovery-code.outputs.recovery-code }} --fail-on-timeout=true --fail-on-cancellation=true --timeout=150 --ios-version=${{ matrix.os-version }} --include-tags=sync --app-file DerivedData/Build/Products/Debug-iphonesimulator/DuckDuckGo.app --flows .maestro/

- name: Reset config
run: |
git checkout .maestro/config.yaml

# notify-failure:
# name: Notify on failure
# if: ${{ always() && contains(join(needs.*.result, ','), 'failure') && github.ref_name == 'main' }}
Expand All @@ -122,7 +122,3 @@ jobs:
# --header "Authorization: Bearer ${{ secrets.ASANA_ACCESS_TOKEN }}" \
# --header "Content-Type: application/json" \
# --data ' { "data": { "name": "GH Workflow Failure - Sync End to end tests", "workspace": "${{ vars.GH_ASANA_WORKSPACE_ID }}", "projects": [ "${{ vars.GH_ASANA_IOS_APP_PROJECT_ID }}" ], "notes" : "The end to end workflow has failed. See https://github.com/duckduckgo/iOS/actions/runs/${{ github.run_id }}" } }'




Loading