Make test_otel more robust to elastic-transport changes #2470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
|
This should not be passing. And indeed, it fails: https://buildkite.com/elastic/elasticsearch-py-integration-tests/builds/1078. Phew. |
|
This should work now that elastic/elastic-transport-python#153 was merged. buildkite test this please (did not work, I retried in the Buildkite UI instead) |
|
Merging to fix the main and 8.13 branches. |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
(cherry picked from commit ce50d9e)
xrmx
reviewed
Mar 14, 2024
iuliaferoli
pushed a commit
to iuliaferoli/elasticsearch-py
that referenced
this pull request
Mar 24, 2024
This was referenced Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on elastic/elastic-transport-python#153