Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed a bug where serialize didn't write out empty vectors and mappings #456

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

johan-gson
Copy link
Contributor

Fixed a bug where serialize didn't write out empty vectors and mappings in a correct way. I have not added a test case, but I tested it in my code and it behaved as expected. Adding a test case at some point would be good.

Regarding the test cases, I couldn't get that to run when I followed the instructions, and don't have time to dig into why. I did test it using my own code though, and it seems to work.

Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • [X ] Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

…appings in a correct way. I have not added a test case, but I tested it in my code and it behaved as expected. Adding a test case at some point would be good.
@johan-gson johan-gson requested a review from fktn-k as a code owner January 5, 2025 20:09
Copy link

github-actions bot commented Jan 5, 2025

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 09d5babee303084ffcb9cebf494f1a43f47f73b7.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr456.zip
ID 2387891368
URL https://github.com/fktn-k/fkYAML/actions/runs/12622591733/artifacts/2387891368

Copy link
Owner

@fktn-k fktn-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@fktn-k
Copy link
Owner

fktn-k commented Jan 6, 2025

Related issue: #454.

@fktn-k fktn-k merged commit c15d671 into fktn-k:develop Jan 6, 2025
163 checks passed
@fktn-k fktn-k added the bug Something isn't working label Jan 9, 2025
@fktn-k fktn-k added this to the Release v0.4.1 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants