-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bug with AIM server availability check #139
fix: bug with AIM server availability check #139
Conversation
8298c7e
to
bf0c857
Compare
@HarikrishnanBalagopal I believe we do not need so much changes to the code. The idea is if Aim is installed but Just change this one line
|
bf0c857
to
626714b
Compare
I think that will also require a change here to avoid adding a fms-hf-tuning/tuning/sft_trainer.py Line 247 in c2f2f8c
|
Wait for #89 which fixes this. |
83963c8
to
1d0a6cf
Compare
Sure, I have made the requested change in this PR as well. |
1d0a6cf
to
30a8a0b
Compare
Signed-off-by: Harikrishnan Balagopal <[email protected]>
30a8a0b
to
c49b3bf
Compare
if this is in #89 perhaps we can close this PR |
@HarikrishnanBalagopal If #89 fixes this issue, lets close this PR. Thanks @anhuong ! |
Description of the change
Fixes the bug in #131
Related issue number
#131
How to verify the PR
Run an end-to-end test using https://github.com/foundation-model-stack/fms-hf-tuning/blob/main/tuning/sft_trainer.py in a
venv
orconda
environment which has the AIM package installed. Even without an AIM server running the training should succeed.Was the PR tested