Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug with AIM server availability check #139

Closed
wants to merge 1 commit into from
Closed

fix: bug with AIM server availability check #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tuning/aim_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,6 @@ def get_aimstack_callback():
if aim_db:
aim_callback = AimCallback(repo=aim_db, experiment=aim_experiment)
else:
aim_callback = AimCallback(experiment=aim_experiment)
aim_callback = None

return aim_callback
4 changes: 3 additions & 1 deletion tuning/sft_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,9 @@ def train(

callbacks = [FileLoggingCallback(logger)]
if is_aim_available():
callbacks.append(get_aimstack_callback())
aimstack_callback = get_aimstack_callback()
if aimstack_callback is not None:
callbacks.append(aimstack_callback)

if (trainer_controller_args is not None) and (
trainer_controller_args.trainer_controller_config_file is not None
Expand Down
Loading