-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic tracker API and implementation of Aimstack tracker #89
Generic tracker API and implementation of Aimstack tracker #89
Conversation
41e01cb
to
bd7cf2f
Compare
f810f50
to
b27ba7e
Compare
b27ba7e
to
9bc30d1
Compare
614a8f7
to
59cd647
Compare
@Ssukriti @alex-jw-brooks some more changes and fixes as requested by @kmehant PR is ready to be reviewed. @tharapalanivel I will run some more e2e tests and bump you, if you have any comments in the meantime on the design, happy to take them. |
@dushyantbehl this is great, thank you! One thing we should be mindful of is that the image build process still works and picks up the new changes. For this we should either change |
Thanks @tharapalanivel should be easy to change it like that. |
59cd647
to
9e749ba
Compare
Signed-off-by: Dushyant Behl <[email protected]>
Signed-off-by: Dushyant Behl <[email protected]>
Signed-off-by: Dushyant Behl <[email protected]>
Signed-off-by: Dushyant Behl <[email protected]>
06ccfc8
to
dbd175b
Compare
Signed-off-by: Dushyant Behl <[email protected]>
dbd175b
to
0388b89
Compare
Co-authored-by: Sukriti Sharma <[email protected]> Signed-off-by: Dushyant Behl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments only on default value of arguments.
By default I want to ensure existing behavior is retained - any users that call .train() or main() function using command line, should see log files like before. So filelogger has to be default for train() and through command line.
Only if aim is explictly passed, it should be used.
ad34c62
to
7eac51f
Compare
Signed-off-by: Dushyant Behl <[email protected]>
7eac51f
to
8507fbf
Compare
Description of the change
Related issue number
How to verify the PR
Example of how new api can be invoked
Was the PR tested