Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/e2e/s3: attach stdout & stderr to exec() errors #1340

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Dec 10, 2024

It may not be immediately obvious that stdout and stderr are actually available when a call to child_process.exec() fails. Attaching them here should bring attention to this, and aid future debugging.

This change assisted in debugging #1339

It may not be immediately obvious that stdout and stderr are actually available when a call to `child_process.exec()` fails.  Attaching them here should bring attention to this, and aid future debugging.
alxndrsn added a commit that referenced this pull request Dec 10, 2024
Node 22 introduced deprecation warnings which changed the stderr output of `lib/bin/s3.js`, breaking a test assertion.

Related #1340 
Closes #1339
@alxndrsn alxndrsn merged commit 2971c71 into getodk:master Dec 10, 2024
6 checks passed
@alxndrsn alxndrsn deleted the s2-e2e-stdout-stderr branch December 10, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants