Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Godot 4 #8

Closed

Conversation

OmarShehata
Copy link

@OmarShehata OmarShehata commented Aug 18, 2023

Updates this add on for Godot 4 (#5). This is NOT backwards compatible, so not sure if we'd want to restructure the repo to have a godot4 folder? Or just make the Godot 4 the canonical one and keep the 3.x version on a branch?

See the 4.0 ported demo project here: godot-extended-libraries/godot-antialiased-line2d-demo#1

90% of the changes here are just the 3.x -> 4.x syntax. One thing I had to add was explicitly setting the texture filter:

texture_filter = TextureFilter.TEXTURE_FILTER_LINEAR_WITH_MIPMAPS

@Calinou
Copy link
Member

Calinou commented Aug 18, 2023

This is NOT backwards compatible, so not sure if we'd want to restructure the repo to have a godot4 folder? Or just make the Godot 4 the canonical one and keep the 3.x version on a branch?

I'd follow the Godot policy, which is to use master for 4.x and a 3.x branch for 3.x. So this PR can be merged directly in master, and I'll create a 3.x branch with the last commit before this PR.

@ThreadAndSandpaper
Copy link

This update to your previous plugin is clearly what I have been looking for... but I'm having an awful time figuring out how to download it. I'm a bit of a beginner and I still find Git very confusing. Do you have plans to make this update available in the official Godot asset library? or is there a place that I can download a .zip?

@Calinou
Copy link
Member

Calinou commented May 21, 2024

or is there a place that I can download a .zip?

https://github.com/OmarShehata/godot-antialiased-line2d/archive/refs/heads/master.zip

For future reference, you can get there by clicking the branch name at the top of the pull request (OmarShehata:master here), clicking the green Code button on the fork's repository page, then Download ZIP at the bottom of the popup.

@ThreadAndSandpaper
Copy link

Thank you so much! And for the 'how to' too!

@OmarShehata
Copy link
Author

ah I forgot about this, I can push that suggested change soon so that this can be merged so it's easier for anyone else who needs this for godot 4 and/or so people can contribute!

@Calinou
Copy link
Member

Calinou commented Jun 26, 2024

Merged manually with ccfc40a. Thanks!

The asset library update will follow soon (it'll be a new asset so the 3.x version remains readily available).

@Calinou Calinou closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants