Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Fill service check background object for pending checks. #24818

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Jan 9, 2025

Fills the service check marker with a grey when in pending state, whereas it was previously empty. I personally found the empty space a little confusing at first glance, whereas having this addition makes it obvious what is happening with the check and that you can hover and see the status.

I chose the colour based on a quick look, trying to find a grey that wasn't too dark, but I don't really know what I am doing, so please let me know what changes to make.

I think it makes sense to backport. Let me know if you think I should add a changelog entry.

Before:
image

After:
image

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

@jrasell jrasell added backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.9.x backport to 1.9.x release line labels Jan 9, 2025
@jrasell jrasell requested a review from philrenaud January 9, 2025 08:38
@jrasell jrasell self-assigned this Jan 9, 2025
@jrasell jrasell requested review from a team as code owners January 9, 2025 08:38
@jrasell
Copy link
Member Author

jrasell commented Jan 9, 2025

I don't have access to Percy to check the changes.

philrenaud
philrenaud previously approved these changes Jan 9, 2025
Copy link
Contributor

@philrenaud philrenaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! If you're ever ever in the mood to check out named-colors in our UI, https://github.com/hashicorp/nomad/blob/main/ui/app/styles/utils/product-colors.scss#L0-L1 and https://github.com/hashicorp/nomad/blob/main/ui/app/styles/utils/structure-colors.scss#L0-L1 are good places to start. That way you don't end up with "magic numbers" hex codes or anything.

@jrasell jrasell merged commit 75d0ac6 into main Jan 15, 2025
22 checks passed
@jrasell jrasell deleted the b-ui-service-check-pending-background-fill branch January 15, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.9.x backport to 1.9.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants