Add support for registering new domains via aws_route53domains_registered_domain

[davidmohar]

Description

Adding support to aws_route53domains_registered_domain that would also allow registration of new domains, not just adopting existing ones. PR is keeping the existing "adopt" implementation as well so that we don't introduce any unwanted or breaking changes. The registration itself is also explicit for now to prevent accidents.

Relations

Closes #37670

Testing Registration

Manually tested with the following base configuration:

resource "aws_route53domains_registered_domain" "this" {
  domain_name = "[domain_name]"
  register    = true
  auto_renew  = true

  admin_privacy      = true
  registrant_privacy = true
  tech_privacy       = true

  ...

  timeouts {
    create = "60m"
    update = "60m"
  }
}

New domain gets properly registered with Route53 Domains ✅

Output from Acceptance Testing

% make testacc TESTS=TestAccRoute53Domains PKG=route53domains
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53domains/... -v -count 1 -parallel 20 -run='TestAccRoute53Domains'  -timeout 360m
=== RUN   TestAccRoute53Domains_serial
=== PAUSE TestAccRoute53Domains_serial
=== CONT  TestAccRoute53Domains_serial
=== RUN   TestAccRoute53Domains_serial/RegisteredDomain
=== RUN   TestAccRoute53Domains_serial/RegisteredDomain/tags
=== RUN   TestAccRoute53Domains_serial/RegisteredDomain/autoRenew
=== RUN   TestAccRoute53Domains_serial/RegisteredDomain/contacts
=== RUN   TestAccRoute53Domains_serial/RegisteredDomain/contactPrivacy
=== RUN   TestAccRoute53Domains_serial/RegisteredDomain/nameservers
=== RUN   TestAccRoute53Domains_serial/RegisteredDomain/transferLock
=== RUN   TestAccRoute53Domains_serial/RegisteredDomain/createRegisterFails
=== RUN   TestAccRoute53Domains_serial/DelegationSignerRecord
=== RUN   TestAccRoute53Domains_serial/DelegationSignerRecord/basic
=== RUN   TestAccRoute53Domains_serial/DelegationSignerRecord/disappears
--- PASS: TestAccRoute53Domains_serial (725.93s)
    --- PASS: TestAccRoute53Domains_serial/RegisteredDomain (548.47s)
        --- PASS: TestAccRoute53Domains_serial/RegisteredDomain/tags (71.83s)
        --- PASS: TestAccRoute53Domains_serial/RegisteredDomain/autoRenew (48.65s)
        --- PASS: TestAccRoute53Domains_serial/RegisteredDomain/contacts (99.09s)
        --- PASS: TestAccRoute53Domains_serial/RegisteredDomain/contactPrivacy (73.59s)
        --- PASS: TestAccRoute53Domains_serial/RegisteredDomain/nameservers (135.52s)
        --- PASS: TestAccRoute53Domains_serial/RegisteredDomain/transferLock (109.50s)
        --- PASS: TestAccRoute53Domains_serial/RegisteredDomain/createRegisterFails (10.28s)
    --- PASS: TestAccRoute53Domains_serial/DelegationSignerRecord (177.46s)
        --- PASS: TestAccRoute53Domains_serial/DelegationSignerRecord/basic (104.41s)
        --- PASS: TestAccRoute53Domains_serial/DelegationSignerRecord/disappears (73.05s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53domains     730.078s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @davidmohar 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRoute53ZonesDataSource_' PKG=route53 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/route53/... -v -count 1 -parallel 3  -run=TestAccRoute53ZonesDataSource_ -timeout 360m -vet=off
2025/01/16 14:17:12 Initializing Terraform AWS Provider...
=== RUN   TestAccRoute53ZonesDataSource_basic
=== PAUSE TestAccRoute53ZonesDataSource_basic
=== CONT  TestAccRoute53ZonesDataSource_basic
--- PASS: TestAccRoute53ZonesDataSource_basic (79.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	84.991s

% make testacc TESTARGS='-run=TestAccRoute53Zone_' PKG=route53 ACCTEST_PARALLELISM=3  
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/route53/... -v -count 1 -parallel 3  -run=TestAccRoute53Zone_ -timeout 360m -vet=off
2025/01/16 14:19:52 Initializing Terraform AWS Provider...
=== RUN   TestAccRoute53Zone_basic
=== PAUSE TestAccRoute53Zone_basic
=== RUN   TestAccRoute53Zone_disappears
=== PAUSE TestAccRoute53Zone_disappears
=== RUN   TestAccRoute53Zone_multiple
=== PAUSE TestAccRoute53Zone_multiple
=== RUN   TestAccRoute53Zone_comment
=== PAUSE TestAccRoute53Zone_comment
=== RUN   TestAccRoute53Zone_delegationSetID
=== PAUSE TestAccRoute53Zone_delegationSetID
=== RUN   TestAccRoute53Zone_forceDestroy
=== PAUSE TestAccRoute53Zone_forceDestroy
=== RUN   TestAccRoute53Zone_ForceDestroy_trailingPeriod
=== PAUSE TestAccRoute53Zone_ForceDestroy_trailingPeriod
=== RUN   TestAccRoute53Zone_tags
=== PAUSE TestAccRoute53Zone_tags
=== RUN   TestAccRoute53Zone_VPC_single
=== PAUSE TestAccRoute53Zone_VPC_single
=== RUN   TestAccRoute53Zone_VPC_multiple
=== PAUSE TestAccRoute53Zone_VPC_multiple
=== RUN   TestAccRoute53Zone_VPC_updates
=== PAUSE TestAccRoute53Zone_VPC_updates
=== RUN   TestAccRoute53Zone_VPC_single_forceDestroy
=== PAUSE TestAccRoute53Zone_VPC_single_forceDestroy
=== RUN   TestAccRoute53Zone_escapedCharacter
=== PAUSE TestAccRoute53Zone_escapedCharacter
=== RUN   TestAccRoute53Zone_classlessDelegation
=== PAUSE TestAccRoute53Zone_classlessDelegation
=== RUN   TestAccRoute53Zone_escapedSlash
=== PAUSE TestAccRoute53Zone_escapedSlash
=== RUN   TestAccRoute53Zone_escapedSpace
=== PAUSE TestAccRoute53Zone_escapedSpace
=== CONT  TestAccRoute53Zone_basic
=== CONT  TestAccRoute53Zone_VPC_single
=== CONT  TestAccRoute53Zone_delegationSetID
--- PASS: TestAccRoute53Zone_basic (86.08s)
=== CONT  TestAccRoute53Zone_tags
--- PASS: TestAccRoute53Zone_delegationSetID (100.92s)
=== CONT  TestAccRoute53Zone_ForceDestroy_trailingPeriod
--- PASS: TestAccRoute53Zone_VPC_single (158.06s)
=== CONT  TestAccRoute53Zone_forceDestroy
--- PASS: TestAccRoute53Zone_tags (103.66s)
=== CONT  TestAccRoute53Zone_escapedCharacter
--- PASS: TestAccRoute53Zone_escapedCharacter (97.87s)
=== CONT  TestAccRoute53Zone_escapedSpace
--- PASS: TestAccRoute53Zone_ForceDestroy_trailingPeriod (240.12s)
=== CONT  TestAccRoute53Zone_escapedSlash
--- PASS: TestAccRoute53Zone_escapedSpace (95.88s)
=== CONT  TestAccRoute53Zone_classlessDelegation
--- PASS: TestAccRoute53Zone_forceDestroy (246.26s)
=== CONT  TestAccRoute53Zone_multiple
=== CONT  TestAccRoute53Zone_comment
--- PASS: TestAccRoute53Zone_escapedSlash (89.23s)
--- PASS: TestAccRoute53Zone_classlessDelegation (80.89s)
=== CONT  TestAccRoute53Zone_disappears
--- PASS: TestAccRoute53Zone_multiple (95.57s)
=== CONT  TestAccRoute53Zone_VPC_single_forceDestroy
--- PASS: TestAccRoute53Zone_comment (91.80s)
=== CONT  TestAccRoute53Zone_VPC_updates
--- PASS: TestAccRoute53Zone_disappears (92.72s)
=== CONT  TestAccRoute53Zone_VPC_multiple
--- PASS: TestAccRoute53Zone_VPC_single_forceDestroy (254.70s)
--- PASS: TestAccRoute53Zone_VPC_multiple (205.14s)
--- PASS: TestAccRoute53Zone_VPC_updates (279.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	806.910s

% make testacc TESTARGS='-run=TestAccRoute53Domains_serial/^Domain$$' PKG=route53domains
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/route53domains/... -v -count 1 -parallel 20  -run=TestAccRoute53Domains_serial/^Domain$ -timeout 360m -vet=off
2025/01/16 15:44:11 Initializing Terraform AWS Provider...
=== RUN   TestAccRoute53Domains_serial
=== PAUSE TestAccRoute53Domains_serial
=== CONT  TestAccRoute53Domains_serial
=== RUN   TestAccRoute53Domains_serial/Domain
=== RUN   TestAccRoute53Domains_serial/Domain/basic
=== RUN   TestAccRoute53Domains_serial/Domain/disappears
=== RUN   TestAccRoute53Domains_serial/Domain/tags
--- PASS: TestAccRoute53Domains_serial (2172.68s)
    --- PASS: TestAccRoute53Domains_serial/Domain (2172.68s)
        --- PASS: TestAccRoute53Domains_serial/Domain/basic (732.22s)
        --- PASS: TestAccRoute53Domains_serial/Domain/disappears (718.05s)
        --- PASS: TestAccRoute53Domains_serial/Domain/tags (715.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53domains	2178.107s