Add support for registering new domains via aws_route53domains_registered_domain

.changelog/37885.txt

@@ -0,0 +1,4 @@
+```new-resource
+aws_route53domains_domain
+```
+

internal/framework/flex/int.go

@@ -21,6 +21,14 @@ func Int64FromFramework(ctx context.Context, v basetypes.Int64Valuable) *int64 {
 	return output
 }
 
+func Int64ValueFromFramework(ctx context.Context, v basetypes.Int64Valuable) int64 {
+	var output int64
+
+	must(Expand(ctx, v, &output))
+
+	return output
+}
+
 // Int64ToFramework converts an int64 pointer to a Framework Int64 value.
 // A nil int64 pointer is converted to a null Int64.
 func Int64ToFramework(ctx context.Context, v *int64) types.Int64 {
@@ -61,7 +69,7 @@ func Int32ToFrameworkLegacy(_ context.Context, v *int32) types.Int64 {
 
 // Int32FromFramework coverts a Framework Int64 value to an int32 pointer.
 // A null Int64 is converted to a nil int32 pointer.
-func Int32FromFramework(ctx context.Context, v types.Int64) *int32 {
+func Int32FromFramework(ctx context.Context, v basetypes.Int64Valuable) *int32 {
 	var output *int32
 
 	must(Expand(ctx, v, &output))
@@ -71,7 +79,7 @@ func Int32FromFramework(ctx context.Context, v types.Int64) *int32 {
 
 // Int32ValueFromFramework coverts a Framework Int64 value to an int32 pointer.
 // A null Int64 is converted to a nil int32 pointer.
-func Int32ValueFromFramework(ctx context.Context, v types.Int64) int32 {
+func Int32ValueFromFramework(ctx context.Context, v basetypes.Int64Valuable) int32 {
 	var output int32
 
 	must(Expand(ctx, v, &output))

internal/framework/planmodifiers/list_default_value_from_path.go

@@ -0,0 +1,53 @@
+// Copyright (c) HashiCorp, Inc.
+// SPDX-License-Identifier: MPL-2.0
+
+package planmodifiers
+
+import (
+	"context"
+
+	"github.com/hashicorp/terraform-plugin-framework/path"
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+	"github.com/hashicorp/terraform-plugin-framework/types/basetypes"
+)
+
+// ListDefaultValueFromPath returns a plan modifier that sets a list's default value
+// from the planned value at another path.
+func ListDefaultValueFromPath[T basetypes.ListValuable](path path.Path) planmodifier.List {
+	return listDefaultValueFromPath[T]{
+		path: path,
+	}
+}
+
+type listDefaultValueFromPath[T basetypes.ListValuable] struct {
+	path path.Path
+}
+
+func (m listDefaultValueFromPath[T]) Description(ctx context.Context) string {
+	return m.MarkdownDescription(ctx)
+}
+
+func (m listDefaultValueFromPath[T]) MarkdownDescription(context.Context) string {
+	return "The default value of this attribute is another attribute's value."
+}
+
+func (m listDefaultValueFromPath[T]) PlanModifyList(ctx context.Context, request planmodifier.ListRequest, response *planmodifier.ListResponse) {
+	// Do nothing if there is a known planned value.
+	if !request.PlanValue.IsUnknown() {
+		return
+	}
+
+	var t T
+	response.Diagnostics.Append(request.Plan.GetAttribute(ctx, m.path, &t)...)
+	if response.Diagnostics.HasError() {
+		return
+	}
+
+	v, diags := t.ToListValue(ctx)
+	response.Diagnostics.Append(diags...)
+	if response.Diagnostics.HasError() {
+		return
+	}
+
+	response.PlanValue = v
+}

internal/framework/planmodifiers/list_default_value_from_path_test.go

@@ -0,0 +1,181 @@
+// Copyright (c) HashiCorp, Inc.
+// SPDX-License-Identifier: MPL-2.0
+
+package planmodifiers_test
+
+import (
+	"context"
+	"testing"
+
+	"github.com/google/go-cmp/cmp"
+	"github.com/hashicorp/terraform-plugin-framework/attr"
+	"github.com/hashicorp/terraform-plugin-framework/path"
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema"
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+	"github.com/hashicorp/terraform-plugin-framework/tfsdk"
+	"github.com/hashicorp/terraform-plugin-framework/types"
+	"github.com/hashicorp/terraform-plugin-go/tftypes"
+	fwplanmodifiers "github.com/hashicorp/terraform-provider-aws/internal/framework/planmodifiers"
+)
+
+func TestListDefaultValueFromPath(t *testing.T) {
+	t.Parallel()
+
+	type testCase struct {
+		request  planmodifier.ListRequest
+		expected planmodifier.ListResponse
+	}
+
+	testSchema := schema.Schema{
+		Attributes: map[string]schema.Attribute{
+			"src": schema.ListAttribute{
+				ElementType: types.StringType,
+			},
+			"dst": schema.ListAttribute{
+				ElementType: types.StringType,
+			},
+		},
+	}
+	nullState := tfsdk.State{
+		Schema: testSchema,
+		Raw: tftypes.NewValue(
+			testSchema.Type().TerraformType(context.Background()),
+			nil,
+		),
+	}
+	testPlan := func(src, dst types.List) tfsdk.Plan {
+		tfSrc, err := src.ToTerraformValue(context.Background())
+
+		if err != nil {
+			panic("ToTerraformValue error: " + err.Error())
+		}
+
+		tfDst, err := dst.ToTerraformValue(context.Background())
+
+		if err != nil {
+			panic("ToTerraformValue error: " + err.Error())
+		}
+
+		return tfsdk.Plan{
+			Schema: testSchema,
+			Raw: tftypes.NewValue(
+				testSchema.Type().TerraformType(context.Background()),
+				map[string]tftypes.Value{
+					"src": tfSrc,
+					"dst": tfDst,
+				},
+			),
+		}
+	}
+	testState := func(src, dst types.List) tfsdk.State {
+		tfSrc, err := src.ToTerraformValue(context.Background())
+
+		if err != nil {
+			panic("ToTerraformValue error: " + err.Error())
+		}
+
+		tfDst, err := dst.ToTerraformValue(context.Background())
+
+		if err != nil {
+			panic("ToTerraformValue error: " + err.Error())
+		}
+
+		return tfsdk.State{
+			Schema: testSchema,
+			Raw: tftypes.NewValue(
+				testSchema.Type().TerraformType(context.Background()),
+				map[string]tftypes.Value{
+					"src": tfSrc,
+					"dst": tfDst,
+				},
+			),
+		}
+	}
+	defaultValue := types.ListValueMust(types.StringType, []attr.Value{types.StringValue("default-value")})
+	computedValue := types.ListValueMust(types.StringType, []attr.Value{types.StringValue("computed-value")})
+	configuredValue := types.ListValueMust(types.StringType, []attr.Value{types.StringValue("configured-value")})
+
+	tests := map[string]testCase{
+		"unknown value on create": {
+			request: planmodifier.ListRequest{
+				State:      nullState,
+				StateValue: types.ListNull(types.StringType),
+				Plan:       testPlan(defaultValue, types.ListUnknown(types.StringType)),
+				PlanValue:  types.ListUnknown(types.StringType),
+			},
+			expected: planmodifier.ListResponse{
+				PlanValue: defaultValue,
+			},
+		},
+		"unknown value on update": {
+			request: planmodifier.ListRequest{
+				State:      testState(defaultValue, computedValue),
+				StateValue: computedValue,
+				Plan:       testPlan(defaultValue, types.ListUnknown(types.StringType)),
+				PlanValue:  types.ListUnknown(types.StringType),
+			},
+			expected: planmodifier.ListResponse{
+				PlanValue: defaultValue,
+			},
+		},
+		"null known value on create": {
+			request: planmodifier.ListRequest{
+				State:      nullState,
+				StateValue: types.ListNull(types.StringType),
+				Plan:       testPlan(types.ListNull(types.StringType), types.ListUnknown(types.StringType)),
+				PlanValue:  types.ListUnknown(types.StringType),
+			},
+			expected: planmodifier.ListResponse{
+				PlanValue: types.ListNull(types.StringType),
+			},
+		},
+		"null known value on update": {
+			request: planmodifier.ListRequest{
+				State:      testState(defaultValue, computedValue),
+				StateValue: computedValue,
+				Plan:       testPlan(types.ListNull(types.StringType), types.ListUnknown(types.StringType)),
+				PlanValue:  types.ListUnknown(types.StringType),
+			},
+			expected: planmodifier.ListResponse{
+				PlanValue: types.ListNull(types.StringType),
+			},
+		},
+		"non-null known value on create": {
+			request: planmodifier.ListRequest{
+				State:      nullState,
+				StateValue: types.ListNull(types.StringType),
+				Plan:       testPlan(defaultValue, configuredValue),
+				PlanValue:  configuredValue,
+			},
+			expected: planmodifier.ListResponse{
+				PlanValue: configuredValue,
+			},
+		},
+		"non-null known value on update": {
+			request: planmodifier.ListRequest{
+				State:      testState(defaultValue, computedValue),
+				StateValue: computedValue,
+				Plan:       testPlan(defaultValue, configuredValue),
+				PlanValue:  configuredValue,
+			},
+			expected: planmodifier.ListResponse{
+				PlanValue: configuredValue,
+			},
+		},
+	}
+
+	for name, test := range tests {
+		t.Run(name, func(t *testing.T) {
+			t.Parallel()
+
+			response := planmodifier.ListResponse{
+				PlanValue: test.request.PlanValue,
+			}
+			fwplanmodifiers.ListDefaultValueFromPath[types.List](path.Root("src")).PlanModifyList(context.Background(), test.request, &response)
+
+			if diff := cmp.Diff(test.expected, response); diff != "" {
+				t.Errorf("unexpected diff (+wanted, -got): %s", diff)
+			}
+		})
+	}
+}

internal/framework/resource_list_of_object.go

@@ -8,7 +8,6 @@ import (
 
 	"github.com/hashicorp/terraform-plugin-framework-validators/listvalidator"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema"
-	"github.com/hashicorp/terraform-plugin-framework/resource/schema/listplanmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/schema/validator"
 	"github.com/hashicorp/terraform-plugin-framework/types"
@@ -17,7 +16,7 @@ import (
 
 // NewResourceComputedListOfObjectSchema returns a new schema.ListAttribute for objects of the specified type.
 // The list is Computed-only.
-func ResourceComputedListOfObjectAttribute[T any](ctx context.Context) schema.ListAttribute {
+func ResourceComputedListOfObjectsAttribute[T any](ctx context.Context) schema.ListAttribute {
 	return schema.ListAttribute{
 		CustomType: fwtypes.NewListNestedObjectTypeOf[T](ctx),
 		Computed:   true,
@@ -27,18 +26,16 @@ func ResourceComputedListOfObjectAttribute[T any](ctx context.Context) schema.Li
 	}
 }
 
-// ResourceOptionalComputedListOfObjectAttribute returns a new schema.ListAttribute for objects of the specified type.
+// ResourceOptionalComputedListOfObjectsAttribute returns a new schema.ListAttribute for objects of the specified type.
 // The list is Optional+Computed.
-func ResourceOptionalComputedListOfObjectAttribute[T any](ctx context.Context) schema.ListAttribute {
+func ResourceOptionalComputedListOfObjectsAttribute[T any](ctx context.Context, sizeAtMost int, planModifiers ...planmodifier.List) schema.ListAttribute {
 	return schema.ListAttribute{
-		CustomType: fwtypes.NewListNestedObjectTypeOf[T](ctx),
-		Optional:   true,
-		Computed:   true,
-		PlanModifiers: []planmodifier.List{
-			listplanmodifier.UseStateForUnknown(),
-		},
+		CustomType:    fwtypes.NewListNestedObjectTypeOf[T](ctx),
+		Optional:      true,
+		Computed:      true,
+		PlanModifiers: planModifiers,
 		Validators: []validator.List{
-			listvalidator.SizeAtMost(1),
+			listvalidator.SizeAtMost(sizeAtMost),
 		},
 		ElementType: types.ObjectType{
 			AttrTypes: fwtypes.AttributeTypesMust[T](ctx),

internal/framework/types/objectof.go

@@ -132,9 +132,16 @@ func (t objectTypeOf[T]) ValueFromObjectPtr(ctx context.Context, ptr any) (attr.
 	return nil, diags
 }
 
-func objectTypeNewObjectPtr[T any](context.Context) (*T, diag.Diagnostics) {
+func objectTypeNewObjectPtr[T any](ctx context.Context) (*T, diag.Diagnostics) {
 	var diags diag.Diagnostics
-	return new(T), diags
+
+	t := new(T)
+	diags.Append(NullOutObjectPtrFields(ctx, t)...)
+	if diags.HasError() {
+		return nil, diags
+	}
+
+	return t, diags
 }
 
 // NullOutObjectPtrFields sets all applicable fields of the specified object pointer to their null values.

internal/service/bedrock/custom_model.go

@@ -140,8 +140,8 @@ func (r *customModelResource) Schema(ctx context.Context, request resource.Schem
 			},
 			names.AttrTags:       tftags.TagsAttribute(),
 			names.AttrTagsAll:    tftags.TagsAttributeComputedOnly(),
-			"training_metrics":   framework.ResourceComputedListOfObjectAttribute[trainingMetricsModel](ctx),
-			"validation_metrics": framework.ResourceComputedListOfObjectAttribute[validatorMetricModel](ctx),
+			"training_metrics":   framework.ResourceComputedListOfObjectsAttribute[trainingMetricsModel](ctx),
+			"validation_metrics": framework.ResourceComputedListOfObjectsAttribute[validatorMetricModel](ctx),
 		},
 		Blocks: map[string]schema.Block{
 			"output_data_config": schema.ListNestedBlock{

internal/service/bedrock/inference_profile.go

@@ -62,7 +62,7 @@ func (r *resourceInferenceProfile) Metadata(_ context.Context, req resource.Meta
 }
 
 func (r *resourceInferenceProfile) Schema(ctx context.Context, req resource.SchemaRequest, resp *resource.SchemaResponse) {
-	modelsAttribute := framework.ResourceComputedListOfObjectAttribute[resourceInferenceProfileModelModel](ctx)
+	modelsAttribute := framework.ResourceComputedListOfObjectsAttribute[resourceInferenceProfileModelModel](ctx)
 	modelsAttribute.PlanModifiers = []planmodifier.List{
 		listplanmodifier.UseStateForUnknown(),
 	}

internal/service/logs/delivery.go

@@ -89,7 +89,7 @@ func (r *deliveryResource) Schema(ctx context.Context, request resource.SchemaRe
 					listplanmodifier.UseStateForUnknown(),
 				},
 			},
-			"s3_delivery_configuration": framework.ResourceOptionalComputedListOfObjectAttribute[s3DeliveryConfigurationModel](ctx),
+			"s3_delivery_configuration": framework.ResourceOptionalComputedListOfObjectsAttribute[s3DeliveryConfigurationModel](ctx, 1, listplanmodifier.UseStateForUnknown()),
 			names.AttrTags:              tftags.TagsAttribute(),
 			names.AttrTagsAll:           tftags.TagsAttributeComputedOnly(),
 		},

internal/service/route53/exports.go

@@ -0,0 +1,10 @@
+// Copyright (c) HashiCorp, Inc.
+// SPDX-License-Identifier: MPL-2.0
+
+package route53
+
+// Exports for use in other modules.
+var (
+	DeleteHostedZone                   = deleteHostedZone
+	FindPublicHostedZoneIDByDomainName = findPublicHostedZoneIDByDomainName
+)