Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODEX cell types: RIBCA, DeepCellTypes #991

Open
wants to merge 6 commits into
base: devel
Choose a base branch
from

Conversation

mruffalo
Copy link
Contributor

This PR adds a submodule for RIBCA, updates the DeepCellTypes submodule, updates SPRM to handle the adjusted output format for both, and adds/updates these in the CODEX DAG.

@mruffalo mruffalo requested a review from jswelling as a code owner December 19, 2024 19:59
return join_quote_command_str(command)

t_build_cmd_ribca = PythonOperator(
task_id="build_cmd_deepcelltypes",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be renamed as "build_cmd_ribca"

Copy link
Collaborator

@sunset666 sunset666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codex DAG is missing the step flow for the new block (before deepcelltypes one):
>> prepare_cwl_ribca
>> t_build_cmd_ribca
>> t_pipeline_exec_cwl_ribca
>> t_maybe_keep_cwl_ribca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants