Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unignore Prague ref tests and remove osakaTime from Prague #8133

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

siladu
Copy link
Contributor

@siladu siladu commented Jan 17, 2025

PR description

No need to ignore Prague tests now (think the specific BLS ignores were all that were required)

Removing osakaTime from Prague Schedule fixes some tests when using https://github.com/ethereum/execution-spec-tests/releases/tag/pectra-devnet-5%40v1.2.0
and doesn't break main.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

genesisStub
.clone()
.pragueTime(0)
.osakaTime(0) // TODO remove this once osaka_devnet_0 ships
Copy link
Contributor Author

@siladu siladu Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shemnon any issue with removing this line?

Removing osakaTime from Prague Schedule fixes some tests when using ethereum/execution-spec-tests@pectra-devnet-5%40v1.2.0 (release).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a there when EOF tests were still in the strange prague fork. OK to remove.

@siladu siladu requested a review from shemnon January 17, 2025 03:58
@siladu siladu removed the request for review from shemnon January 17, 2025 05:49
@siladu siladu changed the title Unignore Prague ref tests and remove osakaTime from Prague ProtocolSchedule Unignore Prague ref tests and remove osakaTime from Prague Jan 17, 2025
@siladu siladu enabled auto-merge (squash) January 17, 2025 06:06
@siladu siladu merged commit 89632d7 into hyperledger:main Jan 17, 2025
43 checks passed
@siladu siladu deleted the unignore-prague-ref-tests branch January 17, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants