Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unignore Prague ref tests and remove osakaTime from Prague #8133

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Unignore Prague ref tests and remove osakaTime from Prague #8133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7520d0b
Unignore Prague ref tests and remove osakaTime from Prague ProtocolSc…
siladu Jan 17, 2025
192dbea
Merge branch 'main' into unignore-prague-ref-tests
siladu Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions ...ain/java/org/hyperledger/besu/ethereum/referencetests/ReferenceTestProtocolSchedules.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,14 +106,7 @@ public static ReferenceTestProtocolSchedules create(final StubGenesisConfigOptio
Map.entry(
"CancunToPragueAtTime15k",
createSchedule(genesisStub.clone().cancunTime(0).pragueTime(15000))),
Map.entry(
"Prague",
createSchedule(
genesisStub
.clone()
.pragueTime(0)
.osakaTime(0) // TODO remove this once osaka_devnet_0 ships
Copy link
Contributor Author

@siladu siladu Jan 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shemnon any issue with removing this line?

Removing osakaTime from Prague Schedule fixes some tests when using ethereum/execution-spec-tests@pectra-devnet-5%40v1.2.0 (release).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a there when EOF tests were still in the strange prague fork. OK to remove.

)),
Map.entry("Prague", createSchedule(genesisStub.clone().pragueTime(0))),
Map.entry("Osaka", createSchedule(genesisStub.clone().osakaTime(0))),
Map.entry("Amsterdam", createSchedule(genesisStub.clone().futureEipsTime(0))),
Map.entry("Bogota", createSchedule(genesisStub.clone().futureEipsTime(0))),
Expand Down
3 changes: 0 additions & 3 deletions ...rc/reference-test/java/org/hyperledger/besu/ethereum/vm/BlockchainReferenceTestTools.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,6 @@ public class BlockchainReferenceTestTools {
// EOF tests don't have Prague stuff like deposits right now
params.ignore("/stEOF/");

// None of the Prague tests have withdrawals and deposits handling
params.ignore("\\[Prague\\]");

// TODO: remove once updated EIP-2537 gas cost artifacts exist
params.ignore("/eip2537_bls_12_381_precompiles/");
params.ignore("/stEIP2537/");
Expand Down
Loading