Separate "define" and "publish" for contract interfaces, and allow deleting unpublished interfaces

[awrichar]

Part of the fix for #1220
In a chain with #1261
Depends on hyperledger/firefly-common#64

[codecov-commenter]

Codecov Report

Merging #1279 (0ffe1b0) into main (56b8d2f) will decrease coverage by 0.03%.
The diff coverage is 97.37%.

❗ Current head 0ffe1b0 differs from pull request most recent head e54db7c. Consider uploading reports for the commit e54db7c to get more accurate results

@@             Coverage Diff             @@
##              main    #1279      +/-   ##
===========================================
- Coverage   100.00%   99.97%   -0.03%     
===========================================
  Files          310      312       +2     
  Lines        20960    21123     +163     
===========================================
+ Hits         20960    21117     +157     
- Misses           0        6       +6     

Impacted Files	Coverage Δ
...erver/route_get_contract_interface_name_version.go	100.00% <ø> (ø)
internal/apiserver/routes.go	100.00% <ø> (ø)
internal/definitions/sender.go	100.00% <ø> (ø)
internal/database/sqlcommon/ffi_sql.go	96.51% <94.82%> (-3.49%)	⬇️
...ernal/apiserver/route_delete_contract_interface.go	100.00% <100.00%> (ø)
...apiserver/route_post_contract_interface_publish.go	100.00% <100.00%> (ø)
...nal/apiserver/route_post_new_contract_interface.go	100.00% <100.00%> (ø)
internal/contracts/manager.go	100.00% <100.00%> (ø)
internal/definitions/handler_contracts.go	100.00% <100.00%> (ø)
internal/definitions/sender_contracts.go	100.00% <100.00%> (ø)

[peterbroadhurst]

Looks great!

Only thing I noticed was that coverage dropped in the SQL package with those updates.
Happy to leave it with you whether to close that before merge.

[peterbroadhurst]

Great to see this case covered 👍

[awrichar]

I double-checked coverage on ffi_sql.go locally and it seems to be covered - so writing off the bot as a mistake. I'll check again after merging though.