-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Handle missing environment variables for local dev #433
Conversation
docker-compose.yml
Outdated
@@ -88,7 +88,7 @@ services: | |||
PRIMARY_HOSTNAME: ${HOST_NAME?missing main hostname (e.g., localhost for development)} | |||
INTERNAL_HOSTNAMES: "web" | |||
DEBUG: ${DEBUG:-0} | |||
SOURCE_REPO_URL: ${SOURCE_REPO_URL:?missing source repository URL} | |||
SOURCE_REPO_URL: ${SOURCE_REPO_URL} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to have a safeguard because SOURCE_REPO_URL
is required for the proper functionality of the services.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unlike MATOMO_*
, SOURCE_REPO_URL
is required for getting data. So better to have this one .env
.
Note that |
I noticed that that's what it says in the Helm chart. SOURCE_REPO_URL: "https://github.com/ietf-tools/" compared to the documentation, https://github.com/ietf-tools/bibxml-service/blob/docs/missing-env-vars/docs/howto/run-in-production.rst, that says
Do you know which one's the correct one? |
I think |
This reverts commit 6727e1a.
Yeah, looks like it's defined in the |
Fixes #432
I could've added
SOURCE_REPO_URL
to.env
in the documentation instead of changingdocker-compose.yml
, but decided to treat it likeMATOMO_URL
,MATOMO_SITE_ID
, etc. at the end. Let me know.