Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsk_naoqi_robot/README] Add explanation of roseus interface methods #1000

Merged
merged 18 commits into from
Dec 11, 2018
Merged

[jsk_naoqi_robot/README] Add explanation of roseus interface methods #1000

merged 18 commits into from
Dec 11, 2018

Conversation

kochigami
Copy link
Contributor

@kochigami kochigami commented Nov 23, 2018 •
edited
Loading

1000!

This was referenced Nov 23, 2018
Merged
Merged
@kochigami
Copy link
Contributor Author

naoqi_appsのkochigami-developがないと動かないものも説明が必要．
例えば，naoqi-interface.lのbackground-movement, external-collision-protection, set-move-arms 関係
peppereusのshow-image関係

kochigami
kochigami commented Nov 26, 2018
View reviewed changes
jsk_naoqi_robot/naoqieus/README.md Outdated
-------

- `:set-master-volume volume` (kochigami-develop)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

どのlaunchファイルを立ち上げればこのメソッドに関係するノードが立ち上がるのか，書いていない

kochigami
kochigami commented Nov 26, 2018
View reviewed changes
jsk_naoqi_robot/peppereus/README.md Outdated

If this kind of error occurs at `tablet.launch`, please re-launch the program.
```
[ERROR] [1543212108.209135]: Exception caught:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一番最後にtrouble shootingとして書く

kochigami
kochigami commented Nov 26, 2018
View reviewed changes
jsk_naoqi_robot/peppereus/README.md Outdated
Methods
-------

- `:show-image file` (kochigami-develop/tablet.launch)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

タブレット表示の仕組み（どこにアクセスするか）を最初に書く

@kochigami kochigami mentioned this pull request Nov 27, 2018
Closed
3 tasks
@kochigami
add more methods explanation: servo, grasp, move, play audio file, al…
0ce18b0 
…ife, external collision, move arms setting, language, background movement, error vector
@kochigami
Copy link
Contributor Author

kochigami commented Dec 5, 2018 •
edited
Loading

added all methods explanation

TODO

  • add naoqi_apps/locomotion_control.launch to kochigami-develop
  • indicate program name (xx.launch) especially if requires kochigami-develop
  • separate doc for each method
  • make them an alphabetical order
  • check typo

@kochigami kochigami mentioned this pull request Dec 5, 2018
Closed
@kochigami kochigami changed the title [WIP] [jsk_naoqi_robot/README] Add explanation of roseus interface methods [jsk_naoqi_robot/README] Add explanation of roseus interface methods Dec 11, 2018
@kochigami
Copy link
Contributor Author

@k-okada

Could you please merge this when you have time?

@k-okada k-okada merged commit 7e9d2d0 into jsk-ros-pkg:master Dec 11, 2018
@kochigami kochigami deleted the add-readme-methods branch December 13, 2018 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
MergeOK naoqi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kochigami @k-okada