This repository has been archived by the owner on Oct 19, 2022. It is now read-only.
Support for marshamallow 3 #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The allow_none keyword argument is lost in the constructor override in this library
Handle lists of string enums
refactor allow lists of enums
|
Retargeted branch to a next-release branch. If this commits could be squashed, I'm happy to merge this. |
|
i can squash these later today. |
|
@justanr @nt1 Please do integrate this - we rely on this package in https://github.com/freezingsaddles/ and have temporarily switched to using the lyft branch as the source of our package instead of using the one that pip can resolve, which is too old to have Marshmallow 3 support. See freezingsaddles/freezing-model#32 for what happens without this fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.