Feature: Support for the facets_form module #399
Conversation
While rendering the facets_form_checkboxes facet widget provided by the facets_form module, groups facet checkboxes according to their LocalGov Directory facet type. This is similar to how the existing `checkbox` facet widget is rendered for LocalGov Directory facets. Resolves #326
Facet checkboxes are provided by the facets_form contrib module.
|
Thanks @Adnan-cds, this works for me. The patch here resolves the issue with unchecking all the checkboxes. |
|
Many thanks for testing this Adrian :) |
There was a problem hiding this comment.
Have also tested this in a default localgov drupal install and with BHCC code base.
Can confirm I do see the facets checkboxes, although it is unstyled which I assume is a theme issue? Maybe could provide a facets form template either here or through localgov_base.
Hi Andy, thanks for testing and approving. There is a new template for the facet checkboxes but, yes, it is unstyled. Given that this pull request introduces an optional feature which won't immediately effect any existing site, should I raise a new ticket to style it? I have to say I am undecided if the Front-end code should go into this repo or localgov_base :) |
|
@Adnan-cds I'd do it on a new branch. I think it might need to be in localgov_base as it will need the same classes as the checkboxes. |
|
Okay Andy, I will raise a ticket in localgov_base and leave it to Chris or Mark. |
While rendering the
facets_form_checkboxfacet widget provided by the facets_form module, this change groups facet checkboxes according to their LocalGov Directory facet type. This is similar to how the existingcheckboxfacet widget is rendered for LocalGov Directory facets.Resolves #326. Replaces #398
What does this change?
Adds support for the facets_form module.
How to test
/admin/config/search/facets/localgov_directories_facets/editCheckboxes (inside form)widget near the top of the page and save settings./admin/structure/block, place theFacet form: View Directory channel, display Embedblock in a sidebar./admin/structure/block.Note: The only way to reset all the facet checkboxes is to click the
Resetbutton. Manually unchecking all facet checkboxes followed by a form submission does not work.How can we measure success?
Usual appearance and behaviour expected for LocalGov Directory facets. Facets should work even without Javascript as we are no longer relying on Javascript to render the checkboxes. The hidden anchor tags with facet links are also not needed. This stops crawlers from following these anchor tags and then getting stuck in a rabbit hole.