-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix treasury spend origin #3130
base: master
Are you sure you want to change the base?
Conversation
WASM runtime size check:Compared to target branchMoonbase runtime: 2272 KB (no changes) ✅ Moonbeam runtime: 2248 KB (no changes) ✅ Moonriver runtime: 2240 KB (no changes) ✅ Compared to latest release (runtime-3400)Moonbase runtime: 2272 KB (+244 KB compared to latest release) Moonbeam runtime: 2248 KB (+236 KB compared to latest release) Moonriver runtime: 2240 KB (+228 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master rq/fix-treasury-spend-origin +/- ##
================================================================
+ Coverage 74.47% 74.59% +0.12%
Files 377 377
+ Lines 95720 96033 +313
================================================================
+ Hits 71283 71632 +349
- Misses 24437 24401 -36
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New tests look good. Failing CI is due to guidelines
, the branding guidelines site, being down and probably in process of being updated; should be safe to ignore.
What does it do?
Following the upgrade to the Polkadot SDK stable2407 (see Update moonbeam to polkadot stable2407 by gonzamontiel · Pull Request #2932 · moonbeam-foundation/moonbeam), a regression was introduced in the runtime that breaks the existing Treasury spending proposal flow (as described here).
Following the upgrade to RT3300, it is not possible anymore to create a Treasury spending proposal:
The proposed correction is to create a
RootOrTreasuryCouncilOrigin
origin (to be configured as SpendOrigin on the Treasury pallet).