Refactor FXIOS-10855 #23671 Reenable rating prompt with different rules #24253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmarceau
changed the title
- Change logic of rating prompt, remove cumulative days of use counter - Call rating prompt on init of BVC - Remove rating prompt from dependency container
lmarceau
force-pushed
the
lm/FXIOS-10855-#23671-rating-prompt
branch
from
aa21c29 to
955ba88
Compare
Client.app: Coverage: 32.33
Generated by 🚫 Danger Swift against b4c6f84 |
mattreaganmozilla
approved these changes
Jan 21, 2025
mattreaganmozilla
approved these changes
Jan 21, 2025
|
@Mergifyio backport release/v135 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
…es (#24253) * - Moved default browser user default to default browser util - Change logic of rating prompt, remove cumulative days of use counter - Call rating prompt on init of BVC - Remove rating prompt from dependency container * Fix tests * Use time interval instead of calendar (cherry picked from commit f1074ee) # Conflicts: # firefox-ios/Client/Application/AppDelegate.swift
Open
6 tasks
clarmso
pushed a commit
that referenced
this pull request
Jan 22, 2025
…es (#24253) * - Moved default browser user default to default browser util - Change logic of rating prompt, remove cumulative days of use counter - Call rating prompt on init of BVC - Remove rating prompt from dependency container * Fix tests * Use time interval instead of calendar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
DefaultBrowserUtil, much cleaner than having this under theRatingPromptManagerCumulativeDaysOfUseCountercode.Rating prompt screenshot
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)