-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor FXIOS-10855 #23671 Reenable rating prompt with different rules (backport #24253) #24272
base: release/v135
Are you sure you want to change the base?
Conversation
…es (#24253) * - Moved default browser user default to default browser util - Change logic of rating prompt, remove cumulative days of use counter - Call rating prompt on init of BVC - Remove rating prompt from dependency container * Fix tests * Use time interval instead of calendar (cherry picked from commit f1074ee) # Conflicts: # firefox-ios/Client/Application/AppDelegate.swift
Cherry-pick of f1074ee has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
4917ecf
to
1ff9631
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is hitting test failures in Bitrise.
Client.app: Coverage: 32.22
Generated by 🚫 Danger Swift against 1ff9631 |
Build is green, there were some flaky tests failures |
📜 Tickets
Jira ticket
Github issue
💡 Description
DefaultBrowserUtil
, much cleaner than having this under theRatingPromptManager
CumulativeDaysOfUseCounter
code.Rating prompt screenshot
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120
)This is an automatic backport of pull request #24253 done by [Mergify](https://mergify.com).