[RFC] video/image_writer: add bgra screenshot support #12149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
reviewed
Aug 13, 2023
| @@ -706,6 +707,9 @@ bool write_image(struct mp_image *image, const struct image_writer_opts *opts, | |||
| int alpha = image->fmt.flags & MP_IMGFLAG_ALPHA; | |||
| destfmt = alpha ? pixfmt2imgfmt(AV_PIX_FMT_YUVA420P) : IMGFMT_420P; | |||
| } | |||
| if (opts->format == AV_CODEC_ID_RAWVIDEO) { | |||
| destfmt = IMGFMT_BGRA; | |||
| } | |||
There was a problem hiding this comment.
I think you're better off writing a new function that dumps the mp_image contents than trying to reuse write_lavc
sfan5
reviewed
Aug 13, 2023
| @@ -557,6 +557,8 @@ Available video output drivers are: | |||
| PNG files. | |||
| webp | |||
| WebP files. | |||
| bgra | |||
| BGRA files. | |||
There was a problem hiding this comment.
something like
Suggested change
| BGRA files. | |
| Raw BGRA (32bpp) pixel data without header or padding. |
would be more descriptive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly for use in scripts that will re-use the screenshots in overlay-add like thumbfast.
The advantage of this over encode mode (which TheAMM's thumbnailer and thumbfast use) is that we can accurately match the user's tonemapping, and screenshots allow dynamic side data in the filename to solve po5/thumbfast#97 (encode mode output filename can't be updated at runtime)
Not ready for merge as it sometimes initially outputs all 0's on HDR files with gpu-next. Making a 2nd screenshot of the same frame correctly renders it.
Does anyone know why this is happening?