Added quotes for Sable #7921
Added quotes for Sable #7921
Conversation
|
Thanks for the contributions! Can you remove the |
data/quotes-runner.edn
Outdated
| {"Default" | ||
| ["Every day, my mission is simple. Acquire credits or starve."] | ||
| "Haas-Bioroid" | ||
| ["Do Bioroids dream of electric sheep?\n" | ||
| "Jinteki" | ||
| ["I wonder what patterns your clones will display today."] | ||
| "NBN" | ||
| ["What lies will you peddle today?\n"]} | ||
| "Weyland" |
There was a problem hiding this comment.
These need to be pairs: the corp faction (or default) and then a series of quotes in double-quotes in the square brackets. And then everything needs to be wrapped in the curly braces.
{"Default" ["quote 1" "quote 2" "quote 3"]
"Haas-Bioroid" ["quote 1" "quote 2" "quote 3"]
"Jinteki" ["quote 1" "quote 2" "quote 3"]
"NBN" ["quote 1" "quote 2" "quote 3"]
"Weyland" ["quote 1" "quote 2" "quote 3"]}As you have it now, Weyland has no associated quotes and is outside of the curly braces.
There was a problem hiding this comment.
Yes! Will correct the \n line formatting and add back the Weyland quote I accidentally removed. Appreciate you catching those errors
There was a problem hiding this comment.
@NoahTheDuke any remaining issues I need to resolve?
data/quotes-runner.edn
Outdated
| {"Default" ["Every day, my mission is simple. Acquire credits or starve."] | ||
| "Haas-Bioroid" ["Do Bioroids dream of electric sheep?"] | ||
| "Jinteki" ["I wonder what patterns your clones will display today."] | ||
| "NBN" ["What lies will you peddle today?] |
There was a problem hiding this comment.
you're missing a closing quote here
|
Assuming that was the last error and we can merge this PR, I'd like to do similar work for:
I have yet to check if Liberation and Borealis corps have quotes |
I noticed Sable was lacking quotes. I wanted to propose these. I pulled them from or were inspired by Threads of Blue.