Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added quotes for Sable #7921

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added quotes for Sable #7921

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac1abc4
Added quotes for Sable
BlueOakData Jan 22, 2025
79b6a8c
Corrected quotes for Sable
BlueOakData Jan 22, 2025
2c6fd0e
Typos
BlueOakData Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion data/quotes-runner.edn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,11 +368,21 @@
"NBN" ["Lies and smokescreens. They are hiding something big. Time to find out what."]
"Weyland"
["No matter how much they build, they'll never bury their secrets deep enough."]}
"Nyusha \"Sable\" Sintashta: Symphonic Prodigy"
{"Default"
["Every day, my mission is simple. Acquire credits or starve."]
"Haas-Bioroid"
["Do Bioroids dream of electric sheep?\n"
"Jinteki"
["I wonder what patterns your clones will display today."]
"NBN"
["What lies will you peddle today?\n"]}
"Weyland"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need to be pairs: the corp faction (or default) and then a series of quotes in double-quotes in the square brackets. And then everything needs to be wrapped in the curly braces.

{"Default" ["quote 1" "quote 2" "quote 3"]
 "Haas-Bioroid" ["quote 1" "quote 2" "quote 3"]
 "Jinteki" ["quote 1" "quote 2" "quote 3"]
 "NBN" ["quote 1" "quote 2" "quote 3"]
 "Weyland" ["quote 1" "quote 2" "quote 3"]}

As you have it now, Weyland has no associated quotes and is outside of the curly braces.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Will correct the \n line formatting and add back the Weyland quote I accidentally removed. Appreciate you catching those errors

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NoahTheDuke any remaining issues I need to resolve?

"Omar Keung: Conspiracy Theorist"
{"Default"
["All my unanswered questions have lead me here. I know it's all connected; here is where the truth will be uncovered. Let's begin."]
"Gagarin Deep Space: Expanding the Horizon"
["What lies and secrets could be so treatcherous as to warrant hiding them so far away?"]
["What lies and secrets could be so treatcherous as to warrant hiding them so far away?\n"]
"Haas-Bioroid"
["With enough time and access to the vast corporate archives, it can be doubtlessly proved that more than half of bioroids have been created without the source mind owner's consent."]
"Jinteki"
Expand Down