-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: clippy lint of 1.84 fixed #1290
Conversation
@@ -75,7 +75,7 @@ async fn setup_worker(contract: Contract) -> anyhow::Result<(Arc<Worker<Sandbox> | |||
fn perform_asserts(total_gas: u64, col: impl Display, override_min_gas: Option<u64>) { | |||
// Constraints a bit relaxed to account for binary differences due to on-demand compilation. | |||
assert!( | |||
total_gas < NearGas::from_tgas(110).as_gas(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has failed (consistently) in 2 attempts, so is considered to have been a performance degrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rust hits hard, haha.
@race-of-sloths include |
@dj8yfo Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 2! @akorchyn received 25 Sloth Points for reviewing and scoring this pull request. We would appreciate your feedback or contribution idea that you can submit here What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1290 +/- ##
==========================================
+ Coverage 80.26% 80.32% +0.06%
==========================================
Files 104 104
Lines 14855 14819 -36
==========================================
- Hits 11924 11904 -20
+ Misses 2931 2915 -16 ☔ View full report in Codecov by Sentry. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1290 +/- ##
==========================================
+ Coverage 80.26% 80.32% +0.06%
==========================================
Files 104 104
Lines 14855 14819 -36
==========================================
- Hits 11924 11904 -20
+ Misses 2931 2915 -16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@race-of-sloths score 2
No description provided.