Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: clippy lint of 1.84 fixed #1290

Merged
merged 2 commits into from
Jan 13, 2025
Merged

ci: clippy lint of 1.84 fixed #1290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2091b02
ci: clippy lint of 1.84 fixed
Jan 9, 2025
d53c72e
chore: increase gas threshold (random_access?) as per performance deg…
Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion near-sdk-macros/src/core_impl/contract_metadata/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@

// adding nep330 if it is not present
if self.standards.is_empty()
|| self.standards.iter().all(|s| s.standard.to_ascii_lowercase() != "nep330")
|| self.standards.iter().all(|s| !s.standard.eq_ignore_ascii_case("nep330"))

Check warning on line 77 in near-sdk-macros/src/core_impl/contract_metadata/mod.rs

View check run for this annotation

Codecov / codecov/patch

near-sdk-macros/src/core_impl/contract_metadata/mod.rs#L77 

Added line #L77 was not covered by tests
{
self.standards
.push(Standard { standard: "nep330".to_string(), version: "1.2.0".to_string() });
Expand Down
2 changes: 1 addition & 1 deletion near-sdk/tests/store_performance_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ async fn setup_worker(contract: Contract) -> anyhow::Result<(Arc<Worker<Sandbox>
fn perform_asserts(total_gas: u64, col: impl Display, override_min_gas: Option<u64>) {
// Constraints a bit relaxed to account for binary differences due to on-demand compilation.
assert!(
total_gas < NearGas::from_tgas(110).as_gas(),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has failed (consistently) in 2 attempts, so is considered to have been a performance degrade

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust hits hard, haha.

total_gas < NearGas::from_tgas(115).as_gas(),
"performance regression {}: {}",
col,
NearGas::from_gas(total_gas)
Expand Down
Loading