Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken taskprocessing api /tasktypes endpoint #50094

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

julien-nc
Copy link
Member

Reported by @alperozturk96 💙

The /ocs/v2.php/taskprocessing/tasktypes was broken by #49015 which changed objects into arrays in the inputShape, outputShape, optionalInputShape etc...

  • Those changes have been reverted
  • Make sure the serialization of the response gives empty objects instead of empty arrays
  • Generate OpenAPI specs

@provokateurin Please put at least @marcelklehr or me as reviewers when making such changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stdClass class missing

@blizzz blizzz mentioned this pull request Jan 8, 2025
@oleksandr-nc
Copy link
Contributor

@provokateurin Please put at least @marcelklehr or me as reviewers when making such changes.

Maybe we need a more precise CODEOWNERS file so that this can be done automatically? (it's hard to remember who is responsible for which file and everyone needs to remember it, which is almost impossible)

@julien-nc julien-nc force-pushed the fix/noid/broken-taskprocessing-api branch from bab6afa to 7bf74f9 Compare January 9, 2025 09:06
@julien-nc julien-nc enabled auto-merge January 9, 2025 09:06
@julien-nc julien-nc merged commit d3ec3de into master Jan 9, 2025
188 checks passed
@julien-nc julien-nc deleted the fix/noid/broken-taskprocessing-api branch January 9, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants