add .summary.social and laborObligations codelist #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncandewhurst
requested changes
Nov 20, 2023
There was a problem hiding this comment.
'will' isn't a normative keyword so I suggested reverting most of the changes to the code descriptions to reinstate it because the 'needs to' alternatives didn't read as well. If I understood it correctly, #404 (comment), was only about changing instances of 'must', 'shall' etc. and pointing out that most code descriptions already used 'will'.
Please update the mapping for labor obligations to add a link to the codelist and to reference the common operation for adding a contracting process document.
Co-authored-by: Duncan Dewhurst <[email protected]>
|
ah, I'd read it as saying that "will" should be removed, I've reverted them all back as suggested. |
duncandewhurst
requested changes
Nov 21, 2023
|
Please re-request review from me after Duncan's review is resolved. |
Co-authored-by: Duncan Dewhurst <[email protected]>
jpmckinney
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
closes #404
closes #406
Description
altered the descriptions in the laborObligations codelist to use non-normative language as suggested in the issue.
Merge checklist
If there are changes to
project-schema.jsonorproject-package-schema.json:docs/examples/example.jsondocs/examples/blank.json./manage.py pre-committo updatedocs/_static/i8n.csvIf you added a new definition to the schema, run
./manage.py pre-commit.If you added a new codelist:
docs/reference/codelists.md