Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tender.sustainability and sustainabilityStrategies.csv #434

Merged
merged 10 commits into from
Nov 28, 2023

Conversation

odscjen
Copy link
Contributor

@odscjen odscjen commented Nov 17, 2023

Related issues
closes #400

Description

the sustainability extension has sustainability as an array of Sustainability objects. But as we're only bringing in Sustainability.strategies I don't think we need to make sustainability an array here, it can be a single instance which is what I've done

Merge checklist

If there are changes to project-schema.json or project-package-schema.json:

  • Update the examples:
    • docs/examples/example.json
    • docs/examples/blank.json
  • Run ./manage.py pre-commit to update docs/_static/i8n.csv

If you added a new definition to the schema, run ./manage.py pre-commit.

If you added a new codelist:

  • Add an entry to docs/reference/codelists.md

@duncandewhurst
Copy link
Contributor

the sustainability extension has sustainability as an array of Sustainability objects. But as we're only bringing in Sustainability.strategies I don't think we need to make sustainability an array here, it can be a single instance which is what I've done

Generally, we've tried to align ContractingProcessSummary.Tender with the Tender definition in OCDS so I'm inclined to think that .sustainability should be an array, as in the extension. @jpmckinney what do you think?

@jpmckinney
Copy link
Member

Let's keep it as an array as in OCDS for consistency and future-proofing.

@odscjen
Copy link
Contributor Author

odscjen commented Nov 21, 2023

I've changed it to an array. I agree about the future proofing but I do think having an array of objects which themselves are made of a single array is potentially confusing.

Copy link
Contributor

@duncandewhurst duncandewhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for you to request a review from James once my comments are resolved.

docs/reference/changelog.md Outdated Show resolved Hide resolved
schema/project-level/project-schema.json Outdated Show resolved Hide resolved
@odscjen odscjen requested a review from jpmckinney November 24, 2023 09:33
@odscjen
Copy link
Contributor Author

odscjen commented Nov 24, 2023

The error is a result of no id field, the test needs changed as discussed #438 (comment)

@jpmckinney jpmckinney merged commit 66106d3 into 0.9-dev Nov 28, 2023
9 of 10 checks passed
@jpmckinney jpmckinney deleted the 400_tender_sustainability branch November 28, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sustainability criteria: capture if sustainability was a criteria of the award decisions
3 participants