-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tender.sustainability and sustainabilityStrategies.csv #434
Conversation
Generally, we've tried to align |
Let's keep it as an array as in OCDS for consistency and future-proofing. |
I've changed it to an array. I agree about the future proofing but I do think having an array of objects which themselves are made of a single array is potentially confusing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy for you to request a review from James once my comments are resolved.
The error is a result of no |
Related issues
closes #400
Description
the sustainability extension has
sustainability
as an array ofSustainability
objects. But as we're only bringing inSustainability.strategies
I don't think we need to makesustainability
an array here, it can be a single instance which is what I've doneMerge checklist
If there are changes to
project-schema.json
orproject-package-schema.json
:docs/examples/example.json
docs/examples/blank.json
./manage.py pre-commit
to updatedocs/_static/i8n.csv
If you added a new definition to the schema, run
./manage.py pre-commit
.If you added a new codelist:
docs/reference/codelists.md