project-schema.json: add benefits array #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncandewhurst
requested changes
Nov 21, 2023
There was a problem hiding this comment.
For compatibility with Flatten Tool, I think that Benefit still needs an .id field because .beneficiaries is an array of objects. Although, I've just remembered that flattening is disabled in the OC4IDS Data Review Tool so I'll defer to @jpmckinney on whether .id is needed.
duncandewhurst
requested changes
Nov 21, 2023
Co-authored-by: Duncan Dewhurst <[email protected]>
This was referenced Nov 24, 2023
removing `wholeListMerge` properties Co-authored-by: Duncan Dewhurst <[email protected]>
|
tests failing due to no |
jpmckinney
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
closes #335
Description
added additional field,
benefit.titlethat was in the example in #335 (comment) but not in the table of new elements which was just an oversight as this field had already been discussed as part of the mapping for one of the relevant new sustainability data points in IDSMerge checklist
If there are changes to
project-schema.jsonorproject-package-schema.json:docs/examples/example.jsondocs/examples/blank.json./manage.py pre-committo updatedocs/_static/i8n.csvIf you added a new definition to the schema, run
./manage.py pre-commit.If you added a new codelist:
docs/reference/codelists.md