fixPPLAllowedFields #181
Merged
fixPPLAllowedFields #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xinyual <[email protected]>
xinyual
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90,
zhichao-aws and
joshuali925
as code owners
zane-neo
reviewed
Feb 4, 2024
| @@ -95,7 +97,28 @@ public class PPLTool implements Tool { | |||
|
|
|||
| private static Map<String, String> defaultPromptDict; | |||
|
|
|||
| private static Set<String> allowedFieldsType; | |||
There was a problem hiding this comment.
Static variables usually follows capital underscore separated naming convention, e.g. ALLOWED_FIELDS_TYPE, please change this one as well as the defaultPromptDict one. Also make them to final since they shouldn't be changed anywhere.
Signed-off-by: xinyual <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
============================================
+ Coverage 81.75% 81.91% +0.16%
Complexity 197 197
============================================
Files 13 13
Lines 1003 1023 +20
Branches 132 134 +2
============================================
+ Hits 820 838 +18
- Misses 133 134 +1
- Partials 50 51 +1 ☔ View full report in Codecov by Sentry. |
zane-neo
approved these changes
Feb 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 4, 2024
* fixPPLAllowedFields Signed-off-by: xinyual <[email protected]> * rename variables Signed-off-by: xinyual <[email protected]> --------- Signed-off-by: xinyual <[email protected]> (cherry picked from commit 9174e4c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
xinyual
pushed a commit
that referenced
this pull request
Feb 4, 2024
* fixPPLAllowedFields * rename variables --------- (cherry picked from commit 9174e4c) Signed-off-by: xinyual <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yuye-aws
pushed a commit
to yuye-aws/skills
that referenced
this pull request
Apr 26, 2024
* fixPPLAllowedFields * rename variables --------- (cherry picked from commit 9174e4c) Signed-off-by: xinyual <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: yuye-aws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix PPL allow fields
Issues Resolved
fix PPL allow fields
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.