OCPBUGS-45103: update variable name for plugin name parsing #14650

yapei · 2024-12-26T08:33:05Z

Before - on CSV details page

within modal

After - on CSV details page

within modal
pseudo translation

openshift-ci-robot · 2024-12-30T01:30:57Z

@yapei: This pull request references Jira Issue OCPBUGS-45103, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.0) matches configured target version for branch (4.19.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Before - on CSV details page

within modal

After - on CSV details page

within modal

pseudo translation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-12-30T01:31:00Z

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yapei.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@yapei: This pull request references Jira Issue OCPBUGS-45103, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)

bug target version (4.19.0) matches configured target version for branch (4.19.0)

bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Before - on CSV details page

within modal

After - on CSV details page

within modal

pseudo translation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Mylanos · 2025-01-10T14:01:44Z

/lgtm

jhadvig · 2025-01-15T13:47:50Z

/retest

│ ✖  add-flow-ci.feature

spadgett

Thanks @yapei !

spadgett · 2025-01-15T13:54:26Z

frontend/packages/operator-lifecycle-manager/src/components/clusterserviceversion.tsx

@@ -294,7 +294,7 @@ const ConsolePlugins: React.FC<ConsolePluginsProps> = ({ csvPlugins, trusted })
          {csvPlugins.map((pluginName) => (
            <dd key={pluginName} className="co-clusterserviceversion-details__field-description">
              {csvPluginsCount > 1 && (
-                <strong className="text-muted">{t('olm~{{plugin}}:', { pluginName })} </strong>
+                <strong className="text-muted">{t('olm~{{pluginName}}:', { pluginName })} </strong>


Not new a problem, but there's nothing to translate here.

Suggested change

<strong className="text-muted">{t('olm~{{pluginName}}:', { pluginName })} </strong>

<strong className="text-muted">{pluginName}</strong>

spadgett · 2025-01-15T13:55:20Z

frontend/packages/console-shared/src/components/modals/ConsolePluginModal.tsx

@@ -41,7 +41,7 @@ export const ConsolePluginModal = withHandlePromise((props: ConsolePluginModalPr
    <form onSubmit={submit} name="form" className="modal-content">
      <ModalTitle>
        {csvPluginsCount > 1
-          ? t('console-shared~Console plugin enablement - {{plugin}}', { pluginName })
+          ? t('console-shared~Console plugin enablement - {{pluginName}}', { pluginName })


I'd suggest this instead so we don't have to re-translate the messages:

Suggested change

? t('console-shared~Console plugin enablement - {{pluginName}}', { pluginName })

? t('console-shared~Console plugin enablement - {{plugin}}', { plugin: pluginName })

spadgett · 2025-01-15T13:58:14Z

/lgtm cancel

I do think we want to consider the suggested changes above so that the messages don't need to be re-translated.

openshift-ci · 2025-01-15T13:59:37Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Mylanos, yapei
Once this PR has been reviewed and has the lgtm label, please assign vikram-raj for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

spadgett · 2025-01-15T14:00:09Z

/label acknowledge-critical-fixes-only
/cherry-pick release-4.18

This is causing failures in our component readiness tests.

openshift-cherrypick-robot · 2025-01-15T14:00:14Z

@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

/label acknowledge-critical-fixes-only
/cherry-pick release-4.18

This is causing failures in our component readiness tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

spadgett · 2025-01-15T14:09:49Z

frontend/packages/console-shared/locales/en/console-shared.json

@@ -182,7 +182,7 @@
  "Run in Web Terminal": "Run in Web Terminal",
  "Successfully copied to clipboard!": "Successfully copied to clipboard!",
  "Running in Web Terminal": "Running in Web Terminal",
-  "Console plugin enablement - {{plugin}}": "Console plugin enablement - {{plugin}}",
+  "Console plugin enablement - {{pluginName}}": "Console plugin enablement - {{pluginName}}",


Hmm, I guess we don't have to retranslate since you've edit the messages manually. This should be OK.

openshift-ci · 2025-01-15T14:31:53Z

@yapei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-console	`be0fd15`	link	true	`/test e2e-gcp-console`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

OCPBUGS-45103 update variable name for plugin name parsing

be0fd15

openshift-ci bot requested review from Mylanos and TheRealJon December 26, 2024 08:33

openshift-ci bot added component/olm Related to OLM component/shared Related to console-shared kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Dec 26, 2024

yapei changed the title ~~OCPBUGS-45103 update variable name for plugin name parsing~~ OCPBUGS-45103: update variable name for plugin name parsing Dec 30, 2024

openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Dec 30, 2024

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Dec 30, 2024

openshift-ci bot assigned Mylanos Jan 10, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2025

spadgett reviewed Jan 15, 2025

View reviewed changes

openshift-ci bot assigned spadgett Jan 15, 2025

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2025

openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 15, 2025

spadgett reviewed Jan 15, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-45103: update variable name for plugin name parsing #14650

OCPBUGS-45103: update variable name for plugin name parsing #14650

yapei commented Dec 26, 2024 •

edited

Loading

openshift-ci-robot commented Dec 30, 2024

openshift-ci bot commented Dec 30, 2024

Mylanos commented Jan 10, 2025

jhadvig commented Jan 15, 2025

spadgett left a comment

spadgett Jan 15, 2025 •

edited

Loading

spadgett Jan 15, 2025

spadgett commented Jan 15, 2025

openshift-ci bot commented Jan 15, 2025

spadgett commented Jan 15, 2025

openshift-cherrypick-robot commented Jan 15, 2025

spadgett Jan 15, 2025

openshift-ci bot commented Jan 15, 2025

	<strong className="text-muted">{t('olm~{{pluginName}}:', { pluginName })} </strong>
	<strong className="text-muted">{pluginName}</strong>

	? t('console-shared~Console plugin enablement - {{pluginName}}', { pluginName })
	? t('console-shared~Console plugin enablement - {{plugin}}', { plugin: pluginName })

OCPBUGS-45103: update variable name for plugin name parsing #14650

Are you sure you want to change the base?

OCPBUGS-45103: update variable name for plugin name parsing #14650

Conversation

yapei commented Dec 26, 2024 • edited Loading

openshift-ci-robot commented Dec 30, 2024

openshift-ci bot commented Dec 30, 2024

Mylanos commented Jan 10, 2025

jhadvig commented Jan 15, 2025

spadgett left a comment

Choose a reason for hiding this comment

spadgett Jan 15, 2025 • edited Loading

Choose a reason for hiding this comment

spadgett Jan 15, 2025

Choose a reason for hiding this comment

spadgett commented Jan 15, 2025

openshift-ci bot commented Jan 15, 2025

spadgett commented Jan 15, 2025

openshift-cherrypick-robot commented Jan 15, 2025

spadgett Jan 15, 2025

Choose a reason for hiding this comment

openshift-ci bot commented Jan 15, 2025

yapei commented Dec 26, 2024 •

edited

Loading

spadgett Jan 15, 2025 •

edited

Loading