Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-45103: update variable name for plugin name parsing #14650

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@
"Run in Web Terminal": "Run in Web Terminal",
"Successfully copied to clipboard!": "Successfully copied to clipboard!",
"Running in Web Terminal": "Running in Web Terminal",
"Console plugin enablement - {{plugin}}": "Console plugin enablement - {{plugin}}",
"Console plugin enablement - {{pluginName}}": "Console plugin enablement - {{pluginName}}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I guess we don't have to retranslate since you've edit the messages manually. This should be OK.

"Console plugin enablement": "Console plugin enablement",
"This operator includes a console plugin which provides a custom interface that can be included in the console. Updating the enablement of this console plugin will prompt for the console to be refreshed once it has been updated. Make sure you trust this console plugin before enabling.": "This operator includes a console plugin which provides a custom interface that can be included in the console. Updating the enablement of this console plugin will prompt for the console to be refreshed once it has been updated. Make sure you trust this console plugin before enabling.",
"This console plugin provides a custom interface that can be included in the console. Updating the enablement of this console plugin will prompt for the console to be refreshed once it has been updated. Make sure you trust this console plugin before enabling.": "This console plugin provides a custom interface that can be included in the console. Updating the enablement of this console plugin will prompt for the console to be refreshed once it has been updated. Make sure you trust this console plugin before enabling.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@
"Run in Web Terminal": "Ejecutar en terminal web",
"Successfully copied to clipboard!": "¡Copiado correctamente al portapapeles!",
"Running in Web Terminal": "Ejecutando en terminal web",
"Console plugin enablement - {{plugin}}": "Habilitación del complemento de consola - {{plugin}}",
"Console plugin enablement - {{pluginName}}": "Habilitación del complemento de consola - {{pluginName}}",
"Console plugin enablement": "Habilitación del complemento de consola",
"This operator includes a console plugin which provides a custom interface that can be included in the console. Updating the enablement of this console plugin will prompt for the console to be refreshed once it has been updated. Make sure you trust this console plugin before enabling.": "Este operador incluye un complemento de consola que proporciona una interfaz personalizada que se puede incluir en la consola. Al actualizar la habilitación de este complemento de la consola, se solicitará que se vuelva a cargar la consola una vez que se haya actualizado. Asegúrese de que este complemento de consola sea confiable antes de habilitarlo.",
"This console plugin provides a custom interface that can be included in the console. Updating the enablement of this console plugin will prompt for the console to be refreshed once it has been updated. Make sure you trust this console plugin before enabling.": "Este complemento de consola proporciona una interfaz personalizada que se puede incluir en la consola. Al actualizar la habilitación de este complemento de la consola, se solicitará que se vuelva a cargar la consola una vez que se haya actualizado. Asegúrese de que este complemento de consola sea confiable antes de habilitarlo.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@
"Run in Web Terminal": "Exécuter dans le terminal Web",
"Successfully copied to clipboard!": "Copié avec succès dans le Presse-papiers !",
"Running in Web Terminal": "Exécution dans le terminal Web",
"Console plugin enablement - {{plugin}}": "Activation du plug-in de console - {{plugin}}",
"Console plugin enablement - {{pluginName}}": "Activation du plug-in de console - {{pluginName}}",
"Console plugin enablement": "Activation du plug-in de console",
"This operator includes a console plugin which provides a custom interface that can be included in the console. Updating the enablement of this console plugin will prompt for the console to be refreshed once it has been updated. Make sure you trust this console plugin before enabling.": "Cet opérateur inclut un plug-in de console qui fournit une interface personnalisée pouvant être incluse dans la console. Lors de la mise à jour de l’activation de ce plug-in de console, vous serez invité à actualiser la console une fois qu’elle aura été mise à jour. Vérifiez qu’il s’agit d’un plug-in de console de confiance avant de l’activer.",
"This console plugin provides a custom interface that can be included in the console. Updating the enablement of this console plugin will prompt for the console to be refreshed once it has been updated. Make sure you trust this console plugin before enabling.": "Ce plug-in de console fournit une interface personnalisée pouvant être incluse dans la console. Lors de la mise à jour de l’activation de ce plug-in de console, vous serez invité à actualiser la console une fois qu’elle aura été mise à jour. Vérifiez qu’il s’agit d’un plug-in de console de confiance avant de l’activer.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@
"Run in Web Terminal": "Web ターミナルでの実行",
"Successfully copied to clipboard!": "クリップボードに正常にコピーされました!",
"Running in Web Terminal": "Web ターミナルでの実行",
"Console plugin enablement - {{plugin}}": "コンソールプラグインの有効化 - {{plugin}}",
"Console plugin enablement - {{pluginName}}": "コンソールプラグインの有効化 - {{pluginName}}",
"Console plugin enablement": "コンソールプラグインの有効化",
"This operator includes a console plugin which provides a custom interface that can be included in the console. Updating the enablement of this console plugin will prompt for the console to be refreshed once it has been updated. Make sure you trust this console plugin before enabling.": "この Operator には、コンソールに追加できるカスタムインターフェースを提供するコンソールプラグインが含まれています。このコンソールプラグインの有効化を更新すると、更新時にコンソールの更新を求めるプロンプトが出されます。このコンソールプラグインを信頼してから有効にするようにしてください。",
"This console plugin provides a custom interface that can be included in the console. Updating the enablement of this console plugin will prompt for the console to be refreshed once it has been updated. Make sure you trust this console plugin before enabling.": "このコンソールプラグインは、コンソールに含めることができるカスタムインターフェースを提供します。このコンソールプラグインの有効化を更新すると、更新時にコンソールの更新を求めるプロンプトが出されます。このコンソールプラグインを信頼してから有効にするようにしてください。",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@
"Run in Web Terminal": "웹 터미널에서 실해ㅇ",
"Successfully copied to clipboard!": "클립 보드에 복사되었습니다!",
"Running in Web Terminal": "웹 터미널에서 실행 중",
"Console plugin enablement - {{plugin}}": "콘솔 플러그인 활성화- {{plugin}}",
"Console plugin enablement - {{pluginName}}": "콘솔 플러그인 활성화- {{pluginName}}",
"Console plugin enablement": "콘솔 플러그인 활성화",
"This operator includes a console plugin which provides a custom interface that can be included in the console. Updating the enablement of this console plugin will prompt for the console to be refreshed once it has been updated. Make sure you trust this console plugin before enabling.": "이 operator에는 콘솔에 포함될 수있는 사용자 정의 인터페이스를 제공하는 콘솔 플러그인이 포함되어 있습니다. 이 콘솔 플러그인의 활성화를 업데이트하면 업데이트된 후 콘솔을 새로 고치라는 메시지가 표시됩니다. 활성화하기 전에 이 콘솔 플러그인을 신뢰하는지 확인하십시오.",
"This console plugin provides a custom interface that can be included in the console. Updating the enablement of this console plugin will prompt for the console to be refreshed once it has been updated. Make sure you trust this console plugin before enabling.": "이 콘솔 플러그인에는 콘솔에 포함할 수 있는 사용자 정의 인터페이스를 제공합니다. 이 콘솔 플러그인의 활성화를 업데이트하면 업데이트된 후 콘솔을 새로 고치라는 메시지가 표시됩니다. 활성화하기 전에 이 콘솔 플러그인을 신뢰하는지 확인하십시오.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@
"Run in Web Terminal": "运行 Web 终端",
"Successfully copied to clipboard!": "成功复制到剪贴板!",
"Running in Web Terminal": "在 Web 终端中运行",
"Console plugin enablement - {{plugin}}": "控制台插件启用 - {{plugin}}",
"Console plugin enablement - {{pluginName}}": "控制台插件启用 - {{pluginName}}",
"Console plugin enablement": "控制台插件启用",
"This operator includes a console plugin which provides a custom interface that can be included in the console. Updating the enablement of this console plugin will prompt for the console to be refreshed once it has been updated. Make sure you trust this console plugin before enabling.": "此 Operator 包含一个控制台插件,它提供了一个可包含在控制台中的自定义接口。更新此控制台插件的启用将提示在控制台更新后刷新控制台。请确保在启用前信任此控制台插件。",
"This console plugin provides a custom interface that can be included in the console. Updating the enablement of this console plugin will prompt for the console to be refreshed once it has been updated. Make sure you trust this console plugin before enabling.": "这个控制台插件提供了一个可包含在控制台中的自定义接口。更新此控制台插件的启用将提示在控制台更新后刷新控制台。请确保在启用前信任此控制台插件。",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export const ConsolePluginModal = withHandlePromise((props: ConsolePluginModalPr
<form onSubmit={submit} name="form" className="modal-content">
<ModalTitle>
{csvPluginsCount > 1
? t('console-shared~Console plugin enablement - {{plugin}}', { pluginName })
? t('console-shared~Console plugin enablement - {{pluginName}}', { pluginName })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest this instead so we don't have to re-translate the messages:

Suggested change
? t('console-shared~Console plugin enablement - {{pluginName}}', { pluginName })
? t('console-shared~Console plugin enablement - {{plugin}}', { plugin: pluginName })

: t('console-shared~Console plugin enablement')}
</ModalTitle>
<ModalBody>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"{{count}} Namespaces_other": "{{count}} Namespaces",
"Console plugin_one": "Console plugin",
"Console plugin_other": "Console plugins",
"{{plugin}}:": "{{plugin}}:",
"{{pluginName}}:": "{{pluginName}}:",
"Enabled": "Enabled",
"Console plugin available": "Console plugin available",
"To let this operator provide a custom interface and run its own code in your console, enable its console plugin in the operator details.": "To let this operator provide a custom interface and run its own code in your console, enable its console plugin in the operator details.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"{{count}} Namespaces_other": "{{count}} espacios de nombres",
"Console plugin_one": "Complemento de consola",
"Console plugin_other": "Complementos de consola",
"{{plugin}}:": "{{plugin}}:",
"{{pluginName}}:": "{{pluginName}}:",
"Enabled": "Activado",
"Console plugin available": "Complemento de consola disponible",
"To let this operator provide a custom interface and run its own code in your console, enable its console plugin in the operator details.": "Para permitir que este operador proporcione una interfaz personalizada y ejecute su propio código en su consola, habilite su complemento de consola en los detalles del operador.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"{{count}} Namespaces_other": "{{count}} espaces de noms",
"Console plugin_one": "Plug-in de console",
"Console plugin_other": "Plug-ins de console",
"{{plugin}}:": "{{plugin}} :",
"{{pluginName}}:": "{{pluginName}} :",
"Enabled": "Activé",
"Console plugin available": "Plug-in de console disponible",
"To let this operator provide a custom interface and run its own code in your console, enable its console plugin in the operator details.": "Pour permettre à cet opérateur de fournir une interface personnalisée et d’exécuter son propre code dans votre console, activez son plug-in de console dans les détails de l’opérateur.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"{{count}} Namespaces_other": "namespace {{count}} 個",
"Console plugin_one": "コンソールプラグイン",
"Console plugin_other": "コンソールプラグイン",
"{{plugin}}:": "{{plugin}}:",
"{{pluginName}}:": "{{pluginName}}:",
"Enabled": "有効化",
"Console plugin available": "利用可能なコンソールプラグイン",
"To let this operator provide a custom interface and run its own code in your console, enable its console plugin in the operator details.": "この Operator がカスタムインターフェースを提供し、コンソールで独自のコードを実行できるようにするには、Operator の詳細でコンソールのプラグインを有効にします。",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"{{count}} Namespaces_other": "{{count}} Namespaces_other",
"Console plugin_one": "콘솔 플로그인",
"Console plugin_other": "콘솔 plugin_other",
"{{plugin}}:": "{{plugin}}:",
"{{pluginName}}:": "{{pluginName}}:",
"Enabled": "활성화됨",
"Console plugin available": "콘솔 플러그인 사용 가능",
"To let this operator provide a custom interface and run its own code in your console, enable its console plugin in the operator details.": "이 operator가 사용자 지정 인터페이스를 제공하고 콘솔에서 자체 코드를 실행하도록하려면 operator 세부 정보에서 해당 콘솔 플러그인을 활성화합니다.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"{{count}} Namespaces_other": "{{count}} 个命名空间",
"Console plugin_one": "控制台插件",
"Console plugin_other": "控制台插件",
"{{plugin}}:": "{{plugin}}:",
"{{pluginName}}:": "{{pluginName}}:",
"Enabled": "已启用",
"Console plugin available": "控制台插件可用",
"To let this operator provide a custom interface and run its own code in your console, enable its console plugin in the operator details.": "要使此 operator 提供自定义接口并在控制台中运行自己的代码,在 operator 详情中启用其控制台扩展。",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ const ConsolePlugins: React.FC<ConsolePluginsProps> = ({ csvPlugins, trusted })
{csvPlugins.map((pluginName) => (
<dd key={pluginName} className="co-clusterserviceversion-details__field-description">
{csvPluginsCount > 1 && (
<strong className="text-muted">{t('olm~{{plugin}}:', { pluginName })} </strong>
<strong className="text-muted">{t('olm~{{pluginName}}:', { pluginName })} </strong>
Copy link
Member

@spadgett spadgett Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not new a problem, but there's nothing to translate here.

Suggested change
<strong className="text-muted">{t('olm~{{pluginName}}:', { pluginName })} </strong>
<strong className="text-muted">{pluginName}</strong>

)}
<Button
data-test="edit-console-plugin"
Expand Down