refactor: ID Pay timeline data refactoring #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastro993
force-pushed
the
idpay-data-refactoring
branch
2 times, most recently
from
5122768 to
d818a9a
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #316 +/- ##
==========================================
+ Coverage 67.71% 67.78% +0.07%
==========================================
Files 144 144
Lines 4984 4992 +8
Branches 603 585 -18
==========================================
+ Hits 3375 3384 +9
+ Misses 1608 1607 -1
Partials 1 1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Hantex9
approved these changes
Nov 16, 2023
mastro993
added a commit
to pagopa/io-app
that referenced
this pull request
Nov 16, 2023
## Short description This PR refactors the `TimelineOperationListItem` component and implements new logic to correctly display `CANCELLED` and `REVERSAL` transactions and CIE onboarding operations. https://github.com/pagopa/io-app/assets/6160324/e5557c07-ba53-4647-be0f-ad39965fb1c7 ## List of changes proposed in this pull request - [ts/features/idpay/details/components/TimelineOperationListItem.tsx](https://github.com/pagopa/io-app/pull/5200/files#diff-bf0f0c12b0c8396401a112111f50ecd7d00a22d176641c354e3880e3879cbd51): splitted `TimelineOperationListItem` into sub-component easier to manage. ## How to test - Tests should solve correctly. - You can test on a simulator/device with the `io-dev-server` on this branch: pagopa/io-dev-api-server#316 --------- Co-authored-by: Martino Cesari Tomba <[email protected]> Co-authored-by: Alessandro Izzo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR refactors the persisted data for ID Pay timeline endpoint
List of changes proposed in this pull request
How to test
Tests should solve correctly