chore: set user email as not mandatory #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #333 +/- ##
=======================================
Coverage 67.73% 67.73%
=======================================
Files 154 154
Lines 5232 5232
Branches 608 608
=======================================
Hits 3544 3544
Misses 1687 1687
Partials 1 1
Continue to review full report in Codecov by Sentry.
|
shadowsheep1
added a commit
to pagopa/io-app
that referenced
this pull request
Dec 14, 2023
## Short description This PR fix an edge case that is present, if a profile coming from BE has an empty email (like with EIC) and the user restart the app, thus restarting their onboarding. <details open><summary>Details</summary> <p> | correct flow | | - | | <video src="https://github.com/pagopa/io-app/assets/16268789/9698a65f-406b-44ed-acd6-10250975f64f" /> | </p> </details> ## How to test With this [io-dev-server PR](pagopa/io-dev-api-server#333), start with a profile without email. When prompt to insert your email, restart the app. You should be block until you set and validate a non empty email. --------- Co-authored-by: Alice Di Rico <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR makes email user field as optional.