Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade new wallet API definitions #340

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

mastro993
Copy link
Contributor

Short description

This PR updates the API definitions for new wallet flows

List of changes proposed in this pull request

  • Updated api_pagopa_walletv3 and api_pagopa_ecommerce definitions
  • Small refactoring to accomodate API changes

How to test

Tests should solve correclty

@mastro993 mastro993 requested a review from a team as a code owner January 22, 2024 11:56
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (235cafb) 67.52% compared to head (a997d49) 67.50%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
- Coverage   67.52%   67.50%   -0.02%     
==========================================
  Files         156      156              
  Lines        5272     5272              
  Branches      615      616       +1     
==========================================
- Hits         3560     3559       -1     
- Misses       1711     1712       +1     
  Partials        1        1              
Files Coverage Δ
src/features/wallet/payloads/paymentMethods.ts 100.00% <ø> (ø)
src/features/wallet/payloads/transactions.ts 60.00% <ø> (ø)
src/features/wallet/utils/onboarding.ts 69.23% <0.00%> (-5.77%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f15bafc...a997d49. Read the comment docs.

@mastro993 mastro993 merged commit a54a095 into master Jan 23, 2024
6 checks passed
@mastro993 mastro993 deleted the update-new-wallet-api-definitions branch January 23, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants