Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade new wallet API definitions #340

Merged
merged 3 commits into from
Jan 23, 2024
Merged

chore: upgrade new wallet API definitions #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
418db16
chore: upgrade api definitions
mastro993 Jan 22, 2024
1e38bb1
fix: failing test
mastro993 Jan 22, 2024
a997d49
Merge branch 'master' into update-new-wallet-api-definitions
forrest57 Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
"api_pn": "https://raw.githubusercontent.com/pagopa/io-backend/v13.25.1-RELEASE/api_pn.yaml",
"api_idpay": "https://raw.githubusercontent.com/pagopa/cstar-infrastructure/v6.5.0/src/domains/idpay-app/api/idpay_appio_full/openapi.appio.full.yml",
"api_fast_login": "https://raw.githubusercontent.com/pagopa/io-backend/v13.25.1-RELEASE/openapi/generated/api_fast_login.yaml",
"api_pagopa_walletv3": "https://raw.githubusercontent.com/pagopa/pagopa-infra/4cd111e94432ff62580adc391de78a5462a7128e/src/domains/wallet-app/api/payment-wallet/v1/_openapi.json.tpl",
"api_pagopa_ecommerce": "https://raw.githubusercontent.com/pagopa/pagopa-infra/65878f9913fcc0eaff499ba8a1a20427a412c010/src/domains/ecommerce-app/api/ecommerce-io/v1/_openapi.json.tpl",
"api_pagopa_walletv3": "https://raw.githubusercontent.com/pagopa/pagopa-infra/740e7dcc5ea2ea19639316fea6797bbd504dd0ae/src/domains/wallet-app/api/payment-wallet/v1/_openapi.json.tpl",
"api_pagopa_ecommerce": "https://raw.githubusercontent.com/pagopa/pagopa-infra/5190135ac34791cf66c1986735d4134bcaf4096f/src/domains/ecommerce-app/api/ecommerce-io/v1/_openapi.json.tpl",
"author": "Matteo Boschi",
"license": "MIT",
"private": false,
Expand Down
5 changes: 2 additions & 3 deletions src/features/wallet/payloads/paymentMethods.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { PaymentMethodStatusEnum } from "../../../../generated/definitions/pagopa/walletv3/PaymentMethodStatus";
import { PaymentMethodsResponse } from "../../../../generated/definitions/pagopa/walletv3/PaymentMethodsResponse";
import { Range } from "../../../../generated/definitions/pagopa/walletv3/Range";
import { TypeEnum } from "../../../../generated/definitions/pagopa/walletv3/WalletInfoDetails";

export const allPaymentMethods: PaymentMethodsResponse = {
paymentMethods: [
Expand All @@ -11,7 +10,7 @@ export const allPaymentMethods: PaymentMethodsResponse = {
description: "Carta di credito",
asset: "creditCard",
status: PaymentMethodStatusEnum.ENABLED,
paymentTypeCode: TypeEnum.CARDS,
paymentTypeCode: "CARDS",
ranges: [
{
min: 0,
Expand All @@ -25,7 +24,7 @@ export const allPaymentMethods: PaymentMethodsResponse = {
description: "PayPal",
asset: "payPal",
status: PaymentMethodStatusEnum.ENABLED,
paymentTypeCode: TypeEnum.PAYPAL,
paymentTypeCode: "PAYPAL",
ranges: [
{
min: 0,
Expand Down
2 changes: 1 addition & 1 deletion src/features/wallet/payloads/transactions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export const getTransactionInfoPayload = (
});

export const getCalculateFeeResponsePayload = (
_walletId: string,
_walletId: string | undefined,
_amount: number
): O.Option<CalculateFeeResponse> =>
O.some({
Expand Down
5 changes: 2 additions & 3 deletions src/features/wallet/utils/onboarding.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,16 @@ import { faker } from "@faker-js/faker";
import { WalletCreateResponse } from "../../../../generated/definitions/pagopa/walletv3/WalletCreateResponse";
import { serverUrl } from "../../../utils/server";
import { PaymentMethodsResponse } from "../../../../generated/definitions/pagopa/walletv3/PaymentMethodsResponse";
import { TypeEnum } from "../../../../generated/definitions/pagopa/walletv3/WalletInfoDetails";
import { allPaymentMethods } from "../payloads/paymentMethods";

export const generateOnboardablePaymentMethods = (): PaymentMethodsResponse =>
allPaymentMethods;

export const getWalletTypeFromPaymentMethodId = (
paymentMethodId: string
): TypeEnum =>
): string =>
allPaymentMethods.paymentMethods?.find(({ id }) => id === paymentMethodId)
?.paymentTypeCode as TypeEnum;
?.paymentTypeCode || "CARDS";

export const WALLET_ONBOARDING_PATH = "/wallets/outcomes";
export const generateOnboardingWalletData = (
Expand Down
2 changes: 1 addition & 1 deletion src/routers/features/idpay/__tests__/payment.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ describe("IDPay Payment API", () => {

describe("DELETE deletePayment", () => {
it("should return 200", async () => {
const trxCode = faker.random.alphaNumeric(8, { bannedChars: "1234567" });
const trxCode = "ABCDEFGH";

const response = await request.delete(
addIdPayPrefix(`/payment/qr-code/${trxCode}`)
Expand Down
Loading