chore: [IOBP-982] Add outcome 99 into mock webview payment page #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hantex9
requested review from
ChrisMattew,
gispada,
freddi301 and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #438 +/- ##
==========================================
- Coverage 64.04% 63.85% -0.20%
==========================================
Files 167 167
Lines 5399 5437 +38
Branches 739 769 +30
==========================================
+ Hits 3458 3472 +14
+ Misses 1940 1820 -120
- Partials 1 145 +144 see 34 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
LeleDallas
approved these changes
Nov 19, 2024
Hantex9
added a commit
to pagopa/io-app
that referenced
this pull request
Nov 20, 2024
## Short description This PR adds outcome 99 inside the payment screen when receiving it from the backend. ## List of changes proposed in this pull request - Created a custom `BE_NODE_KO` that's equals to outcome `99`; - Mapped the new outcome inside the labels and the screen to show into the `WalletPaymentOutcomeScreen.tsx` file; - Added missing outcomes to keep track on mixpanel inside the `getPaymentAnalyticsEventFromFailureOutcome` function ## How to test - Checkout and run the dev-server with this PR: pagopa/io-dev-api-server#438; - Complete the payment flow and choose from the dropdown the BE_NODE_KO; ## Preview https://github.com/user-attachments/assets/a062456d-44a1-4f9f-ae3e-a9fb45644d98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds outcome 99 inside the mocked payment webpage
List of changes proposed in this pull request
BE_NODE_KOinside the dropdown that shows when starting the payment flow in-appHow to test
Describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.