Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/remove time dependency #312

Merged
merged 6 commits into from
Jan 2, 2025
Merged

Feature/remove time dependency #312

merged 6 commits into from
Jan 2, 2025

Conversation

sliu008
Copy link
Contributor

@sliu008 sliu008 commented Dec 23, 2024 •
edited
Loading

Description

  • Remove the dependency that we always need to have a time variable when subsetting

Overview of work done

  • Made getting time function to return None when trying to get time variable
  • Made raise ValueError if we can't find time and were trying to temporal subset
  • Add test cases for getting time function

Overview of verification done

  • Tested locally

PR checklist:

  • Linted
  • Updated unit tests
  • Updated changelog
  • Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

@jamesfwood jamesfwood merged commit 3bbe3f6 into develop Jan 2, 2025
3 checks passed
@jamesfwood jamesfwood deleted the feature/remove_time_dependency branch January 2, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesfwood jamesfwood jamesfwood approved these changes

@frankinspace frankinspace Awaiting requested review from frankinspace

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sliu008 @jamesfwood