Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two small fixes #79

Merged
merged 2 commits into from
Nov 26, 2023
Merged

Two small fixes #79

merged 2 commits into from
Nov 26, 2023

Conversation

KoffeinFlummi
Copy link
Contributor

@KoffeinFlummi KoffeinFlummi commented Nov 25, 2023

Fixes for two problems I encountered while integrating walkers into our application:

  • By fullscreening the widget, violently moving the map around and also switching between tile providers, I was able to make the library panic by killing the IO thread. I assume this is happening because the channel for sending back the downloaded tiles is filling up. I fixed it by using the async version of send, and also downgrading the main thread's response from a panic to simply logging the death of the IO thread, since I don't want the entire application crashing because of that.
  • The map was picking up scroll events when the pointer was outside of the map widget.

- Make download thread wait for channel capacity
- Do not panic in main thread in case download thread dies, to avoid
  crashing the entire application
@podusowski
Copy link
Owner

Makes sense, thanks!

@podusowski podusowski merged commit 951f6e8 into podusowski:main Nov 26, 2023
1 check passed
@KoffeinFlummi KoffeinFlummi deleted the small-fixes branch November 26, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants